Skip to content

Commit 2577466

Browse files
fix(details): fix release tag link
1 parent a8ce110 commit 2577466

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

src/routes/[pid=pid]/[org]/[repo]/[id=number]/+page.server.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ export async function load({ params, fetch }) {
3232
: ("pull" as const)
3333
},
3434
item,
35-
mergedTagName: new Promise<[string, string] | undefined>((resolve, reject) => {
35+
mergedTagName: new Promise<[string, string, string] | undefined>((resolve, reject) => {
3636
// Credit to Refined GitHub: https://github.com/refined-github/refined-github/blob/main/source/features/closing-remarks.tsx
3737
// Get the merged PR's sha, otherwise it is not a proper target for this
3838
if (!("merged" in item.info)) {
@@ -54,11 +54,11 @@ export async function load({ params, fetch }) {
5454
.then(({ tags }) => {
5555
// The info is right here after a little filtering :D
5656
const earliestTag = tags.findLast(tag => !tag.includes("nightly") && /\d[.]\d/.test(tag));
57-
if (!earliestTag) {
57+
if (!earliestTag || !matchingRepo) {
5858
resolve(undefined);
5959
return;
6060
}
61-
resolve(matchingRepo?.metadataFromTag(earliestTag));
61+
resolve([...matchingRepo.metadataFromTag(earliestTag), earliestTag]);
6262
})
6363
.catch(reject);
6464
})

src/routes/[pid=pid]/[org]/[repo]/[id=number]/PageRenderer.svelte

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@
131131
commits: PullRequestDetails["commits"];
132132
files: PullRequestDetails["files"];
133133
linkedEntities: LinkedItem[];
134-
mergedTagName: Promise<[string, string] | undefined>;
134+
mergedTagName: Promise<[string, string, string] | undefined>;
135135
};
136136
137137
let { metadata, info, comments, commits, files, linkedEntities, mergedTagName }: Props = $props();
@@ -425,14 +425,14 @@
425425
</div>
426426
{#await mergedTagName then mergedTag}
427427
{#if mergedTag}
428-
{@const [tagName, tagVersion] = mergedTag}
428+
{@const [tagName, tagVersion, rawTag] = mergedTag}
429429
<Alert.Root class="rounded-md border-green-500 bg-green-400/10">
430430
<Tag class="size-4" />
431431
<Alert.Description class="inline text-foreground">
432432
This pull request was released in
433433
<Button
434434
variant="link"
435-
href="https://github.com/{metadata.org}/{metadata.repo}/releases/tag/{tagName}"
435+
href="https://github.com/{metadata.org}/{metadata.repo}/releases/tag/{rawTag}"
436436
target="_blank"
437437
class="h-auto p-0 text-green-500"
438438
>

0 commit comments

Comments
 (0)