chore(details): code cleanup

Author: WarningImHack3r

src/params/number.ts

@@ -1,3 +1,3 @@
-export function match(value: string) {
+export function match(value) {
 	return /^\d+$/.test(value);
 }

src/params/pid.ts

@@ -1,3 +1,3 @@
-export function match(param: string) {
+export function match(param) {
 	return param === "pull" || param === "issues" || param === "discussions";
 }

src/routes/[pid=pid]/[org]/[repo]/[id=number]/+page.server.ts

@@ -6,11 +6,8 @@ import type { BranchCommit } from "$lib/types";
 
 type Type = "pull" | "issue" | "discussion";
 
-export async function load({ params, fetch }) {
-	const { pid: type, org, repo, id } = params;
-	const numId = +id; // id is already validated by the route matcher
-
-	const item = await githubCache.getItemDetails(org, repo, numId);
+export async function load({ params: { pid: type, org, repo, id }, fetch }) {
+	const item = await githubCache.getItemDetails(org, repo, +id);
 	if (!item) {
 		error(404, `${type} #${id} doesn't exist in repo ${org}/${repo}`);
 	}
@@ -26,7 +23,7 @@ export async function load({ params, fetch }) {
 		itemMetadata: {
 			org,
 			repo,
-			id: numId,
+			id: +id,
 			type: type === "issues" ? "issue" : type === "discussions" ? "discussion" : type
 		} satisfies {
 			type: Type;