Skip to content

Commit ae650c0

Browse files
fix(main-page): fix markdown rendering for /package/all
1 parent e8f7235 commit ae650c0

File tree

2 files changed

+19
-12
lines changed

2 files changed

+19
-12
lines changed

src/routes/package/[...package]/+page.server.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ export async function load({ params, locals }) {
2020
repoName: "",
2121
pkg: {
2222
name: "All packages",
23-
description: "All the packages of this site."
23+
description: "All the packages of this site"
2424
}
2525
} satisfies NonNullable<Awaited<ReturnType<typeof getPackageReleases>>>["releasesRepo"],
2626
releases: await getAllPackagesReleases(categorizedPackages, locals.posthog)

src/routes/package/[...package]/ReleaseCard.svelte

Lines changed: 18 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -45,16 +45,18 @@
4545
let releaseBody = $derived.by(() => {
4646
if (!release.body) return "_No release body_";
4747
// Add missing links to PRs in the release body
48-
return release.body.replace(
49-
/[^[][#\d, ]*?#(\d+)(#issuecomment-\d+)?[#\d, ]*?[^\]]/g,
50-
// Match all `(#1234)` patterns, including `#issuecomment-` ones and multiple in one parenthesis
51-
(match, prNumber, rest) => {
52-
if (!rest) rest = "";
53-
const prUrl = `https://github.com/${repo.owner}/${repo.name}/pull/${prNumber}${rest}`;
54-
// replaceception
55-
return match.replace(`#${prNumber}${rest}`, `[#${prNumber}${rest}](${prUrl})`);
56-
}
57-
);
48+
return repo.owner && repo.name
49+
? release.body.replace(
50+
/[^[][#\d, ]*?#(\d+)(#issuecomment-\d+)?[#\d, ]*?[^\]]/g,
51+
// Match all `(#1234)` patterns, including `#issuecomment-` ones and multiple in one parenthesis
52+
(match, prNumber, rest) => {
53+
if (!rest) rest = "";
54+
const prUrl = `https://github.com/${repo.owner}/${repo.name}/pull/${prNumber}${rest}`;
55+
// replaceception
56+
return match.replace(`#${prNumber}${rest}`, `[#${prNumber}${rest}](${prUrl})`);
57+
}
58+
)
59+
: release.body;
5860
});
5961
let isMajorRelease = $derived(
6062
!release.prerelease &&
@@ -318,7 +320,12 @@
318320
<MarkdownRenderer
319321
markdown={releaseBody}
320322
additionalPlugins={[
321-
{ remarkPlugin: [remarkGithub, { repository: `${repo.owner}/${repo.name}` }] },
323+
{
324+
remarkPlugin:
325+
repo.owner && repo.name
326+
? [remarkGithub, { repository: `${repo.owner}/${repo.name}` }]
327+
: undefined
328+
},
322329
{ remarkPlugin: remarkGemoji },
323330
{ renderer: { li: ListElementRenderer } }
324331
]}

0 commit comments

Comments
 (0)