chore: rename variable, slightly improve error debugging for empty tag name

This error is still crazily mysterious

Author: WarningImHack3r

src/lib/server/github-cache.ts

@@ -893,4 +893,4 @@ export class GitHubCache {
 	}
 }
 
-export const gitHubCache = new GitHubCache(KV_REST_API_URL, KV_REST_API_TOKEN, GITHUB_TOKEN);
+export const githubCache = new GitHubCache(KV_REST_API_URL, KV_REST_API_TOKEN, GITHUB_TOKEN);

src/lib/server/package-discoverer.ts

@@ -1,6 +1,6 @@
 import { type Repository, publicRepos } from "$lib/repositories";
 import type { Prettify } from "$lib/types";
-import { GitHubCache, gitHubCache } from "./github-cache";
+import { GitHubCache, githubCache } from "./github-cache";
 
 type Package = {
 	name: string;
@@ -154,4 +154,4 @@ export class PackageDiscoverer {
 	}
 }
 
-export const discoverer = new PackageDiscoverer(gitHubCache, publicRepos);
+export const discoverer = new PackageDiscoverer(githubCache, publicRepos);

src/routes/[pid=pid]/[org]/[repo]/[id=number]/+page.server.ts

@@ -1,11 +1,11 @@
 import { error, redirect } from "@sveltejs/kit";
-import { gitHubCache } from "$lib/server/github-cache";
+import { githubCache } from "$lib/server/github-cache";
 
 export async function load({ params }) {
 	const { pid: type, org, repo, id } = params;
 	const numId = +id; // id is already validated by the route matcher
 
-	const item = await gitHubCache.getItemDetails(org, repo, numId);
+	const item = await githubCache.getItemDetails(org, repo, numId);
 	if (!item) {
 		error(404, `${type} #${id} doesn't exist in repo ${org}/${repo}`);
 	}

src/routes/package/releases.ts

@@ -1,7 +1,7 @@
 import type { PostHog } from "posthog-node";
 import semver from "semver";
 import type { Repository } from "$lib/repositories";
-import { type GitHubRelease, gitHubCache } from "$lib/server/github-cache";
+import { type GitHubRelease, githubCache } from "$lib/server/github-cache";
 import type { discoverer } from "$lib/server/package-discoverer";
 import type { Prettify } from "$lib/types";
 
@@ -35,7 +35,7 @@ export async function getPackageReleases(
 			if (pkg.name.localeCompare(packageName, undefined, { sensitivity: "base" }) !== 0) continue;
 
 			// 1. Get releases
-			const cachedReleases = await gitHubCache.getReleases({ ...repo, category });
+			const cachedReleases = await githubCache.getReleases({ ...repo, category });
 			console.log(
 				`${cachedReleases.length} releases found for repo ${repo.repoOwner}/${repo.repoName}`
 			);
@@ -45,7 +45,10 @@ export async function getPackageReleases(
 				.filter(release => {
 					if (!release.tag_name) {
 						posthog?.captureException(new Error("Release with null tag_name"), undefined, {
-							release
+							packageName,
+							repoOwner: repo.repoOwner,
+							repoName: repo.repoName,
+							...release
 						});
 						console.warn(`Empty release tag name: ${JSON.stringify(release)}`);
 						return false;
@@ -66,13 +69,6 @@ export async function getPackageReleases(
 			// 3. For each release, check if it is already found, searching by versions
 			const { dataFilter, metadataFromTag, changelogContentsReplacer, ...rest } = repo;
 			for (const release of validReleases) {
-				if (!release.tag_name) {
-					posthog?.captureException(new Error("Release with null tag_name"), undefined, {
-						release
-					});
-					console.warn(`Empty release tag name: ${JSON.stringify(release)}`);
-					continue;
-				}
 				const [cleanName, cleanVersion] = repo.metadataFromTag(release.tag_name);
 				console.log(`Release ${release.tag_name}, extracted version: ${cleanVersion}`);
 				if (foundVersions.has(cleanVersion)) continue;

src/routes/tracker/[org]/[repo]/+page.server.ts

@@ -1,5 +1,5 @@
 import { error } from "@sveltejs/kit";
-import { gitHubCache } from "$lib/server/github-cache";
+import { githubCache } from "$lib/server/github-cache";
 
 // source: https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword
 const closingKeywords = [
@@ -15,16 +15,16 @@ const closingKeywords = [
 ];
 
 export async function load({ params }) {
-	const members = await gitHubCache.getOrganizationMembers(params.org);
+	const members = await githubCache.getOrganizationMembers(params.org);
 	if (!members.length) error(404, `Organization ${params.org} not found or empty`);
 
 	const membersNames = members.map(({ login }) => login);
 	const now = new Date();
 
 	const [unfilteredPRs, unfilteredIssues, unfilteredDiscussions] = await Promise.all([
-		gitHubCache.getAllPRs(params.org, params.repo),
-		gitHubCache.getAllIssues(params.org, params.repo),
-		gitHubCache.getAllDiscussions(params.org, params.repo)
+		githubCache.getAllPRs(params.org, params.repo),
+		githubCache.getAllIssues(params.org, params.repo),
+		githubCache.getAllDiscussions(params.org, params.repo)
 	]);
 	return {
 		prs: unfilteredPRs