Skip to content

Commit 04db9cf

Browse files
authored
Merge pull request EverestAPI#1 from Wartori54/some-tweaks
Remove SDL2_image
2 parents ce48f24 + 6243bef commit 04db9cf

File tree

4 files changed

+3
-50
lines changed

4 files changed

+3
-50
lines changed

.github/workflows/build-libs.yml

Lines changed: 0 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -89,8 +89,6 @@ jobs:
8989
run: |
9090
# SDL2 dependencies
9191
brew install ninja
92-
# SDL2_image dependencies (https://github.com/libsdl-org/SDL_image/blob/0b79762f0a7da2aa05f0673d367994f7eb9ad812/.github/workflows/main.yml#L65-L81)
93-
brew install autoconf automake jpeg-turbo libavif libpng libtiff nasm webp
9492
9593
- name: Install dependencies (Linux)
9694
if: ${{ matrix.platform == 'linux' }}
@@ -104,8 +102,6 @@ jobs:
104102
libxrandr-dev libxcursor-dev libxfixes-dev libxi-dev libxss-dev \
105103
libxkbcommon-dev libdrm-dev libgbm-dev libgl1-mesa-dev libgles2-mesa-dev \
106104
libegl1-mesa-dev libdbus-1-dev libibus-1.0-dev libudev-dev fcitx-libs-dev
107-
# SDL2_image dependencies (https://github.com/libsdl-org/SDL_image/blob/0b79762f0a7da2aa05f0673d367994f7eb9ad812/.github/workflows/main.yml#L82-L100)
108-
sudo apt-get install autoconf automake libavif-dev libjpeg-dev libtiff-dev libtool libwebp-dev nasm zlib1g-dev
109105
110106
# SDL2
111107
- name: Configure SDL2
@@ -141,37 +137,6 @@ jobs:
141137
if: ${{ matrix.platform == 'linux' }}
142138
run: echo "SDL2_LIB=${{ env.SDL2_DIR }}/lib/libSDL2-2.0.so" >> $GITHUB_ENV
143139

144-
# SDL2_image
145-
- name: Configure SDL2_image
146-
working-directory: source/SDL2_image
147-
run: |
148-
export CMAKE_CONFIGURATION_TYPES=${{ env.BUILD_TYPE }}
149-
# JPEG-XL is disabled, because it's causing issues on macOS
150-
cmake -B build -G Ninja \
151-
-DSDL2IMAGE_SAMPLES=ON \
152-
-DSDL2IMAGE_AVIF=ON \
153-
-DSDL2IMAGE_JXL=OFF \
154-
-DSDL2IMAGE_TIF=ON \
155-
-DSDL2IMAGE_WEBP=ON \
156-
-DSDL2IMAGE_VENDORED=ON \
157-
-DSDL2IMAGE_DEBUG_POSTFIX="" \
158-
-DCMAKE_MSVC_RUNTIME_LIBRARY="MultiThreaded$<$<CONFIG:Debug>:Debug>" \
159-
-DCMAKE_INSTALL_PREFIX=cmake_prefix \
160-
-DCMAKE_RUNTIME_OUTPUT_DIRECTORY=$PWD/build \
161-
-DCMAKE_LIBRARY_OUTPUT_DIRECTORY=$PWD/build \
162-
-DCMAKE_BUILD_TYPE=${{ env.BUILD_TYPE }}
163-
164-
- name: Build SDL2_image
165-
working-directory: source/SDL2_image
166-
run: cmake --build build --config ${{ env.BUILD_TYPE }} --verbose --parallel
167-
168-
- name: Install SDL2_image
169-
working-directory: source/SDL2_image
170-
run: |
171-
set -eu
172-
cmake --install build --config ${{ env.BUILD_TYPE }}
173-
echo "SDL2_image_DIR=$(pwd)/cmake_prefix" >> $GITHUB_ENV
174-
175140
# FNA3D + FAudio
176141
- name: Update FNA3D + FAudio CMake version (Windows)
177142
if: ${{ matrix.platform == 'windows' }}
@@ -269,7 +234,6 @@ jobs:
269234
if: ${{ matrix.platform == 'windows' }}
270235
run: |
271236
cp ${{ env.SDL2_DIR }}/bin/SDL2.dll SDL2.dll
272-
cp ${{ env.SDL2_image_DIR }}/bin/SDL2_image.dll SDL2_image.dll
273237
cp source/FNA/lib/FAudio/build/FAudio.dll FAudio.dll
274238
cp source/FNA/lib/FNA3D/build/FNA3D.dll FNA3D.dll
275239
cp source/FNA/lib/Theorafile/libtheorafile.dll libtheorafile.dll
@@ -278,7 +242,6 @@ jobs:
278242
if: ${{ matrix.platform == 'macos' }}
279243
run: |
280244
cp ${{ env.SDL2_DIR }}/lib/libSDL2-2.0.0.dylib libSDL2-2.0.0.dylib
281-
cp ${{ env.SDL2_image_DIR }}/lib/libSDL2_image-2.0.dylib libSDL2_image-2.0.0.dylib
282245
cp source/FNA/lib/FAudio/build/libFAudio.0.dylib libFAudio.0.dylib
283246
cp source/FNA/lib/FNA3D/build/libFNA3D.0.dylib libFNA3D.0.dylib
284247
cp source/FNA/lib/Theorafile/libtheorafile.dylib libtheorafile.dylib
@@ -291,7 +254,6 @@ jobs:
291254
cp source/FNA/bin/${{ env.BUILD_TYPE }}/net7.0/FNA.dll FNA.dll
292255
cp source/FNA/bin/${{ env.BUILD_TYPE }}/net7.0/FNA.pdb FNA.pdb
293256
cp ${{ env.SDL2_DIR }}/lib/libSDL2-2.0.so.0 libSDL2-2.0.so.0
294-
cp ${{ env.SDL2_image_DIR }}/lib/libSDL2_image-2.0.so.0 libSDL2_image-2.0.so.0
295257
cp source/FNA/lib/FAudio/build/libFAudio.so.0 libFAudio.so.0
296258
cp source/FNA/lib/FNA3D/build/libFNA3D.so.0 libFNA3D.so.0
297259
cp source/FNA/lib/Theorafile/libtheorafile.so libtheorafile.so
@@ -303,7 +265,6 @@ jobs:
303265
name: fnalibs-windows-${{ matrix.msys2_env }}
304266
path: |
305267
SDL2.dll
306-
SDL2_image.dll
307268
FAudio.dll
308269
FNA3D.dll
309270
libtheorafile.dll
@@ -315,7 +276,6 @@ jobs:
315276
name: fnalibs-macos-x86_64
316277
path: |
317278
libSDL2-2.0.0.dylib
318-
libSDL2_image-2.0.0.dylib
319279
libFAudio.0.dylib
320280
libFNA3D.0.dylib
321281
libtheorafile.dylib
@@ -331,7 +291,6 @@ jobs:
331291
FNA.dll
332292
FNA.pdb
333293
libSDL2-2.0.so.0
334-
libSDL2_image-2.0.so.0
335294
libFAudio.so.0
336295
libFNA3D.so.0
337296
libtheorafile.so
@@ -485,7 +444,6 @@ jobs:
485444
486445
# Linux x64
487446
cp ../binaries/fnalibs-linux-x86_64/libSDL2-2.0.so.0 lib-vanilla/lib64
488-
cp ../binaries/fnalibs-linux-x86_64/libSDL2_image-2.0.so.0 lib-vanilla/lib64
489447
cp ../binaries/fnalibs-linux-x86_64/libFAudio.so.0 lib-vanilla/lib64
490448
cp ../binaries/fnalibs-linux-x86_64/libFNA3D.so.0 lib-vanilla/lib64
491449
cp ../binaries/fnalibs-linux-x86_64/libtheorafile.so lib-vanilla/lib64

.gitmodules

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,9 @@
44
[submodule "SDL2"]
55
path = source/SDL2
66
url = https://github.com/libsdl-org/SDL/
7-
[submodule "SDL2_image"]
8-
path = source/SDL2_image
9-
url = https://github.com/libsdl-org/SDL_image/
107
[submodule "Piton"]
118
path = source/Piton
12-
url = https://github.com/EverestAPI/Piton
9+
url = https://github.com/Popax21/Piton
1310
[submodule "source/MoltenVK"]
1411
path = source/MoltenVK
1512
url = https://github.com/KhronosGroup/MoltenVK

README.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,19 +8,18 @@ This repository contains the latest libraries needed for Everest in answer to [t
88
These libraries are open source and are built in CI.
99

1010
- SDL2 `2.28.5`
11-
- SDL2_image `2.8.2`
1211
- FNA `24.01`
1312
- FNA3D `24.01`
1413
- FAudio `24.01`
1514
- Theorafile [48d74af](https://github.com/FNA-XNA/Theorafile/tree/48d74afcbf838fe95ca56cec142efae07bb56f65)
1615
- MoltenVK `1.2.11`
1716
- Vulkan Loader `1.3.296`
18-
- Piton [21c7868](https://github.com/EverestAPI/Piton/tree/21c7868d06007f0c5e7d9030a0109fe892df1bf3)
17+
- Piton [21c7868](https://github.com/Popax21/Piton/tree/21c7868d06007f0c5e7d9030a0109fe892df1bf3)
1918

2019
### Closed-Source Libraries
2120
These libraries are closed source and cannot be _built_ in CI.
2221
Some are not accessible without an account, and therefore need to be vendored as a binary blob.
2322

2423
- DiscordGameSDK `3.2.1` (downloaded: https://dl-game-sdk.discordapp.net/3.2.1/discord_game_sdk.zip)
2524
- FMOD Engine `1.10.14` (vendored: [Download (Requires account)](https://www.fmod.com/download#fmodengine), [License](https://github.com/EverestAPI/Everest-libs/blob/main/binaries/fmod/EULA-FMOD.txt))
26-
- Steamworks SDK `1.40` (with Steamworks.NET `10.0.0`) (vendored: [Download (Offical, Requires account)](https://partner.steamgames.com/downloads/list), [Download (via Steamworks.NET)](https://github.com/rlabrecque/Steamworks.NET/releases/tag/10.0.0))
25+
- Steamworks SDK `1.40` (with Steamworks.NET `10.0.0`) (vendored: [Download (Official, Requires account)](https://partner.steamgames.com/downloads/list), [Download (via Steamworks.NET)](https://github.com/rlabrecque/Steamworks.NET/releases/tag/10.0.0))

source/SDL2_image

Lines changed: 0 additions & 1 deletion
This file was deleted.

0 commit comments

Comments
 (0)