Skip to content

Commit 8831a68

Browse files
authored
Upgraded outdated dependencies, updated publish workflow to create Discussion with latest release notes. (#163)
* Upgraded outdated dependencies, updated publish workflow to create Discussion with latest release notes. * Removed validate-input job as it is not needed from publish workflow.
1 parent 2118935 commit 8831a68

File tree

6 files changed

+26
-54
lines changed

6 files changed

+26
-54
lines changed

.github/workflows/publish.yml

Lines changed: 14 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,13 @@ on:
55
inputs:
66
release_type:
77
type: choice
8-
description: 'Release Type'
8+
description: "Release Type"
99
required: true
1010
options:
1111
- major
1212
- minor
1313
- patch
14-
default: 'minor'
14+
default: "minor"
1515

1616
env:
1717
GPG_PRIVATE_KEY: ${{ secrets.GPG_PRIVATE_KEY }}
@@ -20,18 +20,7 @@ env:
2020
NEXUS_PASSWORD: ${{ secrets.NEXUS_PASSWORD }}
2121

2222
jobs:
23-
validate-input:
24-
runs-on: ubuntu-latest
25-
if: ${{ github.event.inputs.release_type == 'major' ||
26-
github.event.inputs.release_type == 'minor' ||
27-
github.event.inputs.release_type == 'patch' }}
28-
steps:
29-
- name: Release Type selected for making release
30-
run: echo "[${{ github.event.inputs.release_type }}] release in progress."
31-
3223
prepare-release-snapshot:
33-
needs:
34-
- validate-input
3524
runs-on: ubuntu-latest
3625
steps:
3726
- name: Check out Git repository
@@ -40,8 +29,8 @@ jobs:
4029
- name: Install Java and Maven
4130
uses: actions/setup-java@v2
4231
with:
43-
java-version: '15'
44-
distribution: 'adopt'
32+
java-version: "15"
33+
distribution: "adopt"
4534

4635
- name: Restore local Maven repository
4736
uses: actions/cache@v2
@@ -83,8 +72,8 @@ jobs:
8372
- name: Install Java and Maven
8473
uses: actions/setup-java@v2
8574
with:
86-
java-version: '15'
87-
distribution: 'adopt'
75+
java-version: "15"
76+
distribution: "adopt"
8877

8978
- name: Restore local Maven repository
9079
uses: actions/cache@v2
@@ -119,8 +108,8 @@ jobs:
119108
- name: Install Java and Maven
120109
uses: actions/setup-java@v2
121110
with:
122-
java-version: '15'
123-
distribution: 'adopt'
111+
java-version: "15"
112+
distribution: "adopt"
124113

125114
- name: Restore local Maven repository
126115
uses: actions/cache@v2
@@ -167,8 +156,8 @@ jobs:
167156
- name: Install Java and Maven
168157
uses: actions/setup-java@v2
169158
with:
170-
java-version: '15'
171-
distribution: 'adopt'
159+
java-version: "15"
160+
distribution: "adopt"
172161

173162
- name: Restore local Maven repository
174163
uses: actions/cache@v2
@@ -205,8 +194,8 @@ jobs:
205194
- name: Install Java and Maven
206195
uses: actions/setup-java@v2
207196
with:
208-
java-version: '15'
209-
distribution: 'adopt'
197+
java-version: "15"
198+
distribution: "adopt"
210199

211200
- name: Download target folder
212201
uses: actions/download-artifact@v2
@@ -289,8 +278,9 @@ jobs:
289278
tag_name: v${{ needs.push-pom.outputs.release-version }}
290279
name: Version ${{ needs.push-pom.outputs.release-version }}
291280
prerelease: false
292-
generate_release_notes: true
293281
draft: false
282+
discussion_category_name: Announcements
283+
generate_release_notes: true
294284
files: |
295285
target/*.jar
296286
target/*.pom

.gitignore

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,9 @@
77
/.classpath
88
/.project
99

10+
# VS Code
11+
/.vscode
12+
1013
# Other output folders
1114
/target/
1215
/bin/

changelogs/CHANGELOG.md

Lines changed: 0 additions & 5 deletions
This file was deleted.

changelogs/latest.md

Lines changed: 0 additions & 15 deletions
This file was deleted.

pom.xml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
<parent>
1111
<groupId>com.github.wasiqb.coteafs</groupId>
1212
<artifactId>parent</artifactId>
13-
<version>3.6.4</version>
13+
<version>3.8.0</version>
1414
</parent>
1515

1616
<scm>
@@ -20,23 +20,23 @@
2020
</scm>
2121

2222
<ciManagement>
23-
<system>Circle CI</system>
24-
<url>https://circleci.com/gh/WasiqB/coteafs-selenium</url>
23+
<system>GitHub Actions</system>
24+
<url>https://github.com/WasiqB/coteafs-selenium/actions</url>
2525
</ciManagement>
2626

2727
<properties>
28-
<coteafs.data.version>1.3.0</coteafs.data.version>
28+
<coteafs.data.version>1.4.0</coteafs.data.version>
2929
<coteafs.error.version>1.15.0</coteafs.error.version>
3030
<log4j.version>2.17.0</log4j.version>
31-
<coteafs.listener.version>3.2.0</coteafs.listener.version>
31+
<coteafs.listener.version>3.3.0</coteafs.listener.version>
3232
<selenium-version>3.141.59</selenium-version>
3333
<commons.io.version>2.11.0</commons.io.version>
34-
<webdrivermanager-version>4.4.3</webdrivermanager-version>
34+
<webdrivermanager-version>5.0.3</webdrivermanager-version>
3535
<faker.version>1.0.2</faker.version>
3636
<commons.text.version>1.9</commons.text.version>
3737
<recorder.version>0.7.7.0</recorder.version>
38-
<lombok.version>1.18.20</lombok.version>
39-
<jackson.version>2.12.4</jackson.version>
38+
<lombok.version>1.18.22</lombok.version>
39+
<jackson.version>2.13.1</jackson.version>
4040
</properties>
4141

4242
<dependencies>

src/main/java/com/github/wasiqb/coteafs/selenium/core/base/driver/ScreenAction.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@
3131

3232
import com.github.wasiqb.coteafs.selenium.config.ScreenshotSetting;
3333
import com.github.wasiqb.coteafs.selenium.core.driver.IDriverActions;
34-
import com.github.wasiqb.coteafs.selenium.core.driver.IScreenAction;
3534
import com.google.common.truth.StringSubject;
3635
import org.apache.logging.log4j.LogManager;
3736
import org.apache.logging.log4j.Logger;
@@ -46,7 +45,7 @@
4645
* @author Wasiq Bhamla
4746
* @since 27-Jul-2019
4847
*/
49-
public class ScreenAction<D extends WebDriver> extends BaseDriverAction<D> implements IScreenAction, IDriverActions<D> {
48+
public class ScreenAction<D extends WebDriver> extends BaseDriverAction<D> implements IDriverActions<D> {
5049
private static final Logger LOG = LogManager.getLogger ();
5150

5251
protected static void pause (final long delay) {

0 commit comments

Comments
 (0)