feat(Anvil): read notes

- Finished the anvil interface.
- Rewrote item related colors that were "housed" under `RSColors` and now you have them in `TRSItem` or `ERSStack` e.g.:
```pascal
WriteLn TRSItem.Border;
WriteLn ERSStack.YELLOW.Color;
```

Author: Torwent

osrs/finders/itemfinder.simba

@@ -27,53 +27,70 @@ type
     Unzipping, IsSetup: Boolean;
   end;
 
-function TRSItemFinder.Align(image, template: TImage): Boolean;
+
+function TRSItemFinder._AlignHelper(img: TImage; tBorder, border: TPointArray; out align: TPoint): Boolean;
 var
-  borderA, borderB, tmp1, tmp2: TPointArray;
-  bounds: TBox;
-  align, p: TPoint;
+  color: TColor;
+  pt: TPoint;
 begin
-  borderA := image.FindColor(RSColors.ITEM_BORDER, 0);
-  tmp1    := borderA.ExcludeBox([0,0,image.Width,8]);
-  borderA := tmp1;
-  borderB := template.FindColor($000000, 1) + template.FindColor(RSColors.ITEM_BORDER_WHITE, 0);
-  tmp2    := borderB.ExcludeBox([0,0,template.Width,8]);
-  borderB := tmp2;
+  if border = [] then Exit;
 
-  if (borderA.Length = 0) or (borderB.Length = 0) then Exit;
+  align := tBorder.Last - border.Last;
+  border := border.Offset(align);
 
-  align := borderA[High(borderA)] - borderB[High(borderB)];
-  borderB := borderB.Offset(align);
+  color := TRSItem.Border;
 
-  for p in borderB do
+  for pt in border do
   begin
-    if p.Y <= 8 then Continue;//stack number... Don't compare.
-
-    if not image.InImage(p.X, p.Y) then Exit;
-    if (image.Pixel[p.X, p.Y] <> RSColors.ITEM_BORDER) then Exit;
+    if pt.Y <= 8 then
+      Continue; //stack number... Don't compare.
+    if not img.InImage(pt.X, pt.Y) then
+      Exit;
+    if img.Pixel[pt.X, pt.Y] <> color then
+      Exit;
   end;
 
-  bounds := borderA.Bounds;
+  Result := True;
+end;
+
+function TRSItemFinder.Align(image, template: TImage): Boolean;
+var
+  tBorder, bBorder, wBorder: TPointArray;
+  bounds: TBox;
+  align: TPoint;
+begin
+  tBorder := image.FindColor(TRSItem.Border, 0).ExcludeBox([0,0,image.Width,8]);
+  bBorder := template.FindColor(TRSItem.Border, 0).ExcludeBox([0,0,template.Width,8]);
+  wBorder := template.FindColor(TRSItem.BorderWhite, 0);
+
+  if tBorder = [] then
+    Exit;
+
+  if not Self._AlignHelper(image, tBorder, bBorder, align) and
+     not Self._AlignHelper(image, tBorder, wBorder, align) then
+    Exit;
+
+  bounds := tBorder.Bounds;
   image.Crop(bounds);
   template.Crop(bounds.Offset([-align.X, -align.Y]));
   Result := True;
 end;
 
 procedure TRSItemFinder.Clean(image, template: TImage);
 var
-  color: TColor;
+  stack: ERSStack;
   tpa: TPointArray;
 begin
   image.DrawColor := $0;
   template.DrawColor := $0;
 
   template.DrawTPA(image.FindColor($0, 0));
 
-  tpa := image.FindColor(RSColors.ITEM_SHADOW, 0);
-  for color in RSColors.STACK_COLORS do
-    tpa += template.FindColor(color, 0);
+  tpa := image.FindColor(TRSItem.Shadow, 0);
+  for stack := Low(ERSStack) to High(ERSStack) do
+    tpa += template.FindColor(stack.Color, 0);
 
-  tpa += template.FindColor(RSColors.ITEM_BORDER, 0);
+  tpa += template.FindColor(TRSItem.Border, 0);
   image.DrawTPA(tpa);
   template.DrawTPA(tpa);
 end;
@@ -262,7 +279,7 @@ begin
       for i := 0 to High(boxes) do
       begin
         if skip[i] then Continue;
-        if not RSColors.HasItem(boxes[i]) then
+        if not TRSItem.InBounds(boxes[i]) then
         begin
           skip[i] := True;
           Continue;
@@ -303,7 +320,7 @@ begin
       for i := 0 to High(boxes) do
       begin
         if skip[i] then Continue;
-        if not RSColors.HasItem(boxes[i]) then
+        if not TRSItem.InBounds(boxes[i]) then
         begin
           skip[i] := True;
           Continue;
@@ -353,7 +370,7 @@ begin
       for i := 0 to High(boxes) do
       begin
         if skip[i] then Continue;
-        if not RSColors.HasItem(boxes[i]) then
+        if not TRSItem.InBounds(boxes[i]) then
         begin
           skip[i] := True;
           Continue;
@@ -398,7 +415,7 @@ var
   tpa: TPointArray;
   border: TImage;
 begin
-  tpa := img.FindColor(RSColors.ITEM_BORDER, 0, [0, 9, 35, 31]);
+  tpa := img.FindColor(TRSItem.Border, 0, [0, 9, 35, 31]);
   if tpa = [] then Exit;
   border := new TImage(36, 32);
   border.DrawColor := $FFFFFF;

osrs/interfaces/gametabs/achievements.simba

@@ -378,7 +378,7 @@ Internal method used to count the available tabs on the {ref}`Achievements` game
 *)
 function TRSAchievements.CountTabs(): Integer;
 begin
-  Result := Length(Target.FindColor(RSColors.ITEM_BORDER, 0, Self.TabsArea).Cluster(1.5));
+  Result := Length(Target.FindColor(TRSItem.Border, 0, Self.TabsArea).Cluster(1.5));
 end;
 
 (*

osrs/interfaces/gametabs/inventory.simba

@@ -47,7 +47,6 @@ Internal method used to setup the {ref}`TRSInventory` coordinates.
 
 This is automatically called for you on the {ref}`Inventory variable`.
 *)
-
 function TRSInventory.Open(): Boolean; forward;
 
 procedure TRSInventory.SetupGameTab();
@@ -127,7 +126,7 @@ WriteLn Inventory.IsSelected('Vial');
 function TRSInventory.IsSelected(slot: TBox): Boolean;
 begin
   slot.Y1 += 8;
-  Result := Target.HasColor(RSColors.ITEM_BORDER_WHITE, 1, 1, slot);
+  Result := Target.HasColor(TRSItem.BorderWhite, 1, 1, slot);
 end;
 
 function TRSInventory.IsSelected(slot: Integer): Boolean; overload;

osrs/interfaces/gametabs/stats.simba

@@ -229,7 +229,7 @@ begin
   if not Self.Open() then Exit(-1);
 
   with Self.Skills[skill] do
-    Result := OCR.RecognizeNumber([X1, Y2 - (Height div 2), X2, Y2], RSFonts.PLAIN_11, [RSColors.STACK_YELLOW], 0);
+    Result := OCR.RecognizeNumber([X1, Y2 - (Height div 2), X2, Y2], RSFonts.PLAIN_11, [ERSStack.YELLOW.Color], 0);
 
   if Result > 0 then
     Self.Levels[skill] := Result;