fix: some more form utils wrappers

- also some misc tweaks

Author: Torwent

osrs/interfaces/mainscreen/anvil.simba

@@ -183,7 +183,8 @@ begin
     if Target.HasColor(RSFonts.BLACK, 0,  1, Self.QuantityButtons[i].Bounds) then
       btns += Self.QuantityButtons[i];
 
-  if btns = [] then Exit;
+  if btns = [] then
+    Exit;
 
   case value of
     -1, 0: str := 'All';
@@ -344,7 +345,7 @@ begin
     Exit;
 
   obj.Walker^.WaitMoving();
-  Result := Self.WaitOpen(3000);
+  Result := Self.WaitOpen(6*TICK);
 end;
 
 function TRSAnvil.Open(walk: Boolean = True): Boolean; overload;

osrs/position/map/mapdebugger.simba

@@ -67,7 +67,7 @@ begin
     for i := 0 to High(Self.Graph.ObjectClusters) do
       canvas.DrawPoints(Self.Graph.ObjectClusters[i], Self.ColorArray[i]);
 
-  if Self.ShowGraph then
+  if Self.ShowGraph and (Self.Graph.Nodes <> []) then
   begin
     Self.Graph.Draw(canvas);
     if Self.Selected > -1 then
@@ -126,7 +126,7 @@ begin
 
   Self.Selected := Self.Graph.Nodes.NearestIndex(pt);
 
-  if pt.InRange(Self.Graph.Nodes[Self.Selected].Node, 4) then
+  if (Self.Graph.Nodes <> []) and pt.InRange(Self.Graph.Nodes[Self.Selected].Node, 4) then
   begin
     g := Self.GetGlobal(Self.Graph.Nodes[Self.Selected].Node);
 

osrs/position/map/maploader.simba

@@ -316,7 +316,6 @@ If no .bmp file exists, the .png file is loaded instead, it's saved as .bmp for
 function TRSMapLoader.GetFile(chunk: TPoint; plane: Integer; map: ERSMap): TImage;
 var
   filename, cachename: String;
-  created: Boolean;
 begin
   filename := ToStr(chunk.X) + '-' + ToStr(chunk.Y);
   Result := new TImage();
@@ -331,12 +330,13 @@ begin
   begin
     if not FileExists(cachename + '.png') then
     begin
-      created := True;
       Result.SetSize(RSTranslator.Map.ChunkSide, RSTranslator.Map.ChunkSide);
-    end;
-
-    if not created then
+      if not DirCreate(PathExtractDir(cachename)) then
+        raise GetDebugLn('MapLoader', 'Failed to create path: ' + PathExtractDir(cachename));
+    end
+    else
       Result.Load(cachename + '.png');
+
     Result.Save(cachename + '.bmp');
     FileDelete(cachename + '.png');
     Exit;

utils/forms/formutils.simba

@@ -222,6 +222,17 @@ begin
 end;
 
 
+property TLazControl.Right: Integer;
+begin
+  Result := Self.Left+Self.Width;
+end;
+
+property TLazControl.Bottom: Integer;
+begin
+  Result := Self.Top+Self.Height;
+end;
+
+
 
 property TLazSizeConstraints.MinWidth(value: Integer); override;
 begin

utils/ocr.simba

@@ -54,8 +54,8 @@ var
   colors: TColorArray;
 begin
   img := Target.GetImage(bounds);
-  shadows := img.FindColor(0, 2.5, [1, 1, img.Width - 1, img.Height - 1]);
-  shadows := Shadows.Offset([-1,-1]).ExcludePoints(shadows);
+  shadows := img.FindColor($0, 2.5, [1, 1, img.Width - 1, img.Height - 1]);
+  shadows := shadows.Offset([-1,-1]).ExcludePoints(shadows);
 
   colors := img.GetColors(shadows).Unique();
   img.ReplaceColorBinary(False, colors, tolerance);