fix(Bank): better DepositDifferent

Author: Torwent

osrs/interfaces/iteminterface.simba

@@ -367,26 +367,45 @@ begin
 end;
 
 
+function TRSItemInterface._GetShadowHash(slot: Integer): String;
+var
+  b: TBox;
+begin
+  with Self.Slots^.Box(slot) do
+  begin
+    b.X1 := X1 + Self.DiscoverOffset.X;
+    b.Y1 := Y1 + Self.DiscoverOffset.Y;
+  end;
 
-function TRSItemInterface._Discover(slot: Integer): TRSItemArray;
+  b.X2 := b.X1 + 35;
+  b.Y2 := b.Y1 + 31;
+
+  Result := ItemFinder.GetBorderHash(Target.GetImage(b));
+end;
+
+function TRSItemInterface._GetHash(slot: Integer): String;
 var
   b: TBox;
-  img: TImage;
-  hash: String;
 begin
-  b := Self.Slots^.Box(slot);
-  b.X1 += Self.DiscoverOffset.X;
-  b.Y1 += Self.DiscoverOffset.Y;
+  with Self.Slots^.Box(slot) do
+  begin
+    b.X1 := X1 + Self.DiscoverOffset.X;
+    b.Y1 := Y1 + Self.DiscoverOffset.Y;
+  end;
+
   b.X2 := b.X1 + 35;
   b.Y2 := b.Y1 + 31;
 
-  if (b.Width <> 36) or (b.Height <> 32) then
-    raise GetDebugLn(Self.Name, 'Discover box has to be 36x32. You passed w: ' + ToStr(b.Width) + ' h: ' + ToStr(b.Height));
+  Result := ItemFinder.GetHash(Target.GetImage(b));
+end;
 
-  img := Target.GetImage(b);
-  hash := ItemFinder.GetHash(img);
-  if hash = '' then Exit;
-  Result := ItemFinder.GetHashItems(hash);
+function TRSItemInterface._Discover(slot: Integer): TRSItemArray;
+var
+  hash: String;
+begin
+  hash := Self._GetHash(slot);
+  if hash <> '' then
+    Result := ItemFinder.GetHashItems(hash);
 end;
 
 function TRSItemInterface.Discover(slot: Integer): TRSItemArray;

osrs/interfaces/mainscreen/bank.simba

@@ -1191,13 +1191,21 @@ function TRSBank.DepositDifferent(items: TRSItemArray; useQuantityButton: Boolea
 var
   slots: TIntegerArray;
   slot: Integer;
+  hash: String;
+  deposited: TStringArray;
 begin
   slots := Inventory.Items.FindDifferent(items);
   if slots = [] then Exit(True);
 
   for slot in slots do
-    if not Self._InteractionHelper(ERSBankInteraction.DEPOSIT, Inventory.Slots.Box(slot), 1, useQuantityButton) then
+  begin
+    hash := Inventory.Items._GetHash(slot);
+    if deposited.Contains(hash) then
+      Continue;
+    deposited += hash;
+    if not Self._InteractionHelper(ERSBankInteraction.DEPOSIT, Inventory.Slots.Box(slot), QUANTITY_ALL, useQuantityButton) then
       Exit;
+  end;
   Result := True;
 end;
 

osrs/interfaces/minimap.simba

@@ -722,7 +722,7 @@ position on the minimap at 0º.
 Example:
 ```pascal
 pt := Minimap.RandomPoint(Minimap.Center, 30);
-angle := Minimap.GetCompassAngle(False);
+angle := Minimap.CompassRadians;
 pt := Minimap.Normalize(pt, angle);
 ShowOnTarget(TCircle.Create(pt.X, pt.Y, 6));
 ```