fix: several small fixes to antiban and graphgen

Author: Torwent

osrs/antiban/antibanform.simba

@@ -787,7 +787,10 @@ begin
 
 
   Self.TaskVariationSpinner := TLazFloatSpinEdit.CreateEx(lPanel, '', 'Edit the currently selected task interval variation.');
-  Self.TaskVariationSpinner.Text := '3.3';
+  Self.TaskVariationSpinner.Value := 0.33;
+  Self.TaskVariationSpinner.MinValue := 0;
+  Self.TaskVariationSpinner.MaxValue := 1;
+  Self.TaskVariationSpinner.Increment := 0.05;
   Self.TaskVariationSpinner.Align := ELazAlign.Top;
   Self.TaskVariationSpinner.BorderSpacing.Left := 10;
   Self.TaskVariationSpinner.BorderSpacing.Right := 10;
@@ -909,7 +912,7 @@ begin
   Self.BreakLogoutSpinner.MinValue  := 0.00;
   Self.BreakLogoutSpinner.MaxValue  := 1.00;
   Self.BreakLogoutSpinner.Increment := 0.10;
-  Self.BreakLogoutSpinner.Text := '0.05';
+  Self.BreakLogoutSpinner.Value := 0.05;
   Self.BreakLogoutSpinner.Align := ELazAlign.Top;
   Self.BreakLogoutSpinner.BorderSpacing.Left := 10;
   Self.BreakLogoutSpinner.BorderSpacing.Right := 10;
@@ -922,7 +925,10 @@ begin
   lbl.BorderSpacing.Right := 10;
 
   Self.BreakVariationSpinner := TLazFloatSpinEdit.CreateEx(lPanel);
-  Self.BreakVariationSpinner.Text := '3.3';
+  Self.BreakVariationSpinner.Value := 0.33;
+  Self.BreakVariationSpinner.MinValue := 0;
+  Self.BreakVariationSpinner.MaxValue := 1;
+  Self.BreakVariationSpinner.Increment := 0.05;
   Self.BreakVariationSpinner.Align := ELazAlign.Top;
   Self.BreakVariationSpinner.BorderSpacing.Left := 10;
   Self.BreakVariationSpinner.BorderSpacing.Right := 10;

utils/webgraphgen.simba

@@ -361,7 +361,7 @@ begin
   end;
 end;
 
-function TWebGraphGenerator.ConnectLastDoors(out graph: TWebGraph; idx, door: Integer; constref tree: TKDPointTree): TGraphNodeArray;
+procedure TWebGraphGenerator.ConnectLastDoors(out graph: TWebGraph; idx, door: Integer; constref tree: TKDPointTree);
 var
   p, q: TPoint;
   i, j: Integer;
@@ -510,36 +510,35 @@ var
   i, j: Integer;
   t: UInt64;
 begin
-  white := map.FindColor($FFFFFF, 0);
-  red := map.FindColor($0000FF, 0);
-
-  WriteLn GetDebugLn('Generating webgraph for region: ' + name);
-
+  WriteLn GetDebugLn('Generating webgraph for region: ' + name + ' this can take a few seconds.');
   t := GetTimeRunning();
-  Result := Self._BuildGraph(map, white, red);
 
+  white := map.FindColor($FFFFFF, 0);
+  red := map.FindColor($0000FF, 0);
   gray := map.FindColor($333333, 0);
 
+  Result := Self._BuildGraph(map, white, red);
   grayClusters := gray.Cluster(1);
 
   for i := 0 to High(Self.WhiteClusters) do
   begin
-    if Length(Self.WhiteClusters[i]) <= 6 then Continue;
+    if Length(Self.WhiteClusters[i]) <= 6 then
+      Continue;
 
     graySubset := gray.ExtractBox(Self.WhiteClusters[i].Bounds().Expand(80));
     merged := Self.WhiteClusters[i] + graySubset;
     mergedClusters := merged.Cluster(1);
 
-    for j := 0 to high(mergedClusters) do
+    for j := 0 to High(mergedClusters) do
       if mergedClusters[j].Contains(Self.WhiteClusters[i][0]) then
       begin
         Result.WalkableClusters += mergedClusters[j];
         Break;
       end;
   end;
 
-  Result.WalkableSpace    := white + gray;
-  Result.ObjectClusters   := grayClusters;
+  Result.WalkableSpace  := white + gray;
+  Result.ObjectClusters := grayClusters;
 
   Self.WhiteClusters := [];
   WriteLn GetDebugLn('WebGraphGenerator', 'Generating webgraph took ' + ToStr(Round(((GetTimeRunning()-t)/1000), 2)) + ' seconds.', ELogLevel.SUCCESS);