updated wrapper (#207)

Author: JamesPHoughton

cypress/downloads/downloads.html

@@ -1,6 +1,6 @@
 {
   "name": "@watts-lab/surveys",
-  "version": "1.19.1",
+  "version": "1.19.2",
   "description": "",
   "main": "dist/index.js",
   "module": "dist/index.js",

package-lock.json

@@ -1,6 +1,6 @@
 import "survey-react/modern.min.css";
 import * as SurveyJS from "survey-react";
-import React, { useEffect, useRef, useCallback } from "react";
+import React, { useEffect, useRef, useCallback, useMemo } from "react";
 import packageJson from "../package.json";
 import { labeledRange } from "./customQuestionTypes/labeledRange";
 
@@ -15,8 +15,11 @@ export default function SurveyFactory(surveyName, surveyJson, scoreFunc, sha) {
   function BuiltSurvey({ onComplete, storageName, language }) {
     const timerStartedAt = useRef(Date.now());
 
-    const surveyModel = new SurveyJS.Model(surveyJson);
-    surveyModel.locale = language; // set the language for the survey
+    const surveyModel = useMemo(() => {
+      const model = new SurveyJS.Model(surveyJson);
+      model.locale = language; // set the language for the survey
+      return model;
+    }, [language, surveyJson]);
 
     const saveState = useCallback(
       (survey) => {
@@ -75,8 +78,13 @@ export default function SurveyFactory(surveyName, surveyJson, scoreFunc, sha) {
       surveyModel.onValueChanged.add(saveState);
       surveyModel.onCurrentPageChanged.add(saveState);
 
-      return () => saveState(surveyModel);
-    }, [saveState, scoreResponses, clearStorage]);
+      return () => {
+        saveState(surveyModel);
+        surveyModel.onComplete.remove(scoreResponses);
+        surveyModel.onValueChanged.remove(saveState);
+        surveyModel.onCurrentPageChanged.remove(saveState);
+      };
+    }, [saveState, scoreResponses, surveyModel]);
 
     var prevData = window.localStorage.getItem(storageName) || null;
     if (prevData) {

package.json

@@ -1 +1 @@
-{"survey":"4ae36797ea34ed7c4cb004447623e22d4a5315bc","score":"4df0f09da3993bdca1a11c534442042d2054d2b2"}
+{"survey":"063caac4425b739d6a89b605ed621d2abd2ebd6c","score":"4df0f09da3993bdca1a11c534442042d2054d2b2"}