Skip to content

Commit 493d068

Browse files
committed
dss-server: fix rollback
1 parent 6311373 commit 493d068

File tree

2 files changed

+4
-21
lines changed

2 files changed

+4
-21
lines changed

dss-framework/dss-framework-orchestrator-server/src/main/java/com/webank/wedatasphere/dss/orchestrator/server/service/impl/OrchestratorFrameworkServiceImpl.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -474,8 +474,9 @@ public GitHistoryResponse getHistory(Long workspaceId, Long orchestratorId, Stri
474474
String newCommitId = versionByOrchestratorId.get(0).getCommitId();
475475
commitInfoBetweenRequest.setNewCommitId(newCommitId);
476476
String oldCommitId = null;
477+
int i = 0;
477478
for (DSSOrchestratorVersion version : versionByOrchestratorId) {
478-
if (version.getCommitId()!= null && !version.getCommitId().equals(newCommitId)) {
479+
if (version.getCommitId()!= null && i++ != 0) {
479480
oldCommitId = version.getCommitId();
480481
break;
481482
}

dss-framework/dss-framework-orchestrator-server/src/main/java/com/webank/wedatasphere/dss/orchestrator/server/service/impl/OrchestratorServiceImpl.java

Lines changed: 2 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -442,26 +442,8 @@ public void rollbackOrchestratorGit(OrchestratorRollBackGitVo rollBackGitVo, Str
442442
DSSOrchestratorVersion dssOrchestratorVersion = rollBackGitVo.getDssOrchestratorVersion();
443443
DSSProject projectInfo = DSSFlowEditLockManager.getProjectInfo(projectId);
444444
if (projectInfo.getAssociateGit() != null && projectInfo.getAssociateGit()) {
445-
try {
446-
DSSFlow dssFlow = flowMapper.selectFlowByID(dssOrchestratorVersion.getAppId());
447-
if (!dssFlow.getName().equals(dssOrchestratorInfo.getName())) {
448-
lockMapper.updateOrchestratorStatus(orchestratorId, OrchestratorRefConstant.FLOW_STATUS_SAVE);
449-
return ;
450-
}
451-
Sender sender = DSSSenderServiceFactory.getOrCreateServiceInstance().getGitSender();
452-
//若之前版本未进行git回滚,则自动提交回滚后的工作流至git
453-
if (StringUtils.isEmpty(oldOrcVersion.getCommitId())) {
454-
lockMapper.updateOrchestratorStatus(orchestratorId, OrchestratorRefConstant.FLOW_STATUS_SAVE);
455-
} else {
456-
GitRevertRequest gitRevertRequest = new GitRevertRequest(workspace.getWorkspaceId(), projectName, oldOrcVersion.getCommitId(), dssOrchestratorInfo.getName(), "system");
457-
GitCommitResponse gitCommitResponse = RpcAskUtils.processAskException(sender.ask(gitRevertRequest), GitCommitResponse.class, GitRevertRequest.class);
458-
lockMapper.updateOrchestratorVersionCommitId(gitCommitResponse.getCommitId(), dssOrchestratorVersion.getAppId());
459-
lockMapper.updateOrchestratorStatus(orchestratorId, OrchestratorRefConstant.FLOW_STATUS_PUBLISH);
460-
}
461-
} catch (Exception e) {
462-
lockMapper.updateOrchestratorStatus(orchestratorId, OrchestratorRefConstant.FLOW_STATUS_SAVE);
463-
throw e;
464-
}
445+
DSSFlow dssFlow = flowMapper.selectFlowByID(dssOrchestratorVersion.getAppId());
446+
lockMapper.updateOrchestratorStatus(orchestratorId, OrchestratorRefConstant.FLOW_STATUS_SAVE);
465447
}
466448

467449
}

0 commit comments

Comments
 (0)