fix bug #448

Author: JackChen0810

dss-apps/dss-apiservice-server/src/main/java/com/webank/wedatasphere/dss/apiservice/core/bo/ApiCommentUpdateRequest.java

@@ -0,0 +1,37 @@
+/*
+ * Copyright 2019 WeBank
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+package com.webank.wedatasphere.dss.apiservice.core.bo;
+
+public class ApiCommentUpdateRequest {
+   private Long id;
+   private String comment;
+
+    public Long getId() {
+        return id;
+    }
+
+    public void setId(Long id) {
+        this.id = id;
+    }
+
+    public String getComment() {
+        return comment;
+    }
+
+    public void setComment(String comment) {
+        this.comment = comment;
+    }
+}

dss-apps/dss-apiservice-server/src/main/java/com/webank/wedatasphere/dss/apiservice/core/restful/ApiServiceCoreRestfulApi.java

@@ -16,6 +16,7 @@
 
 package com.webank.wedatasphere.dss.apiservice.core.restful;
 
+import com.webank.wedatasphere.dss.apiservice.core.bo.ApiCommentUpdateRequest;
 import com.webank.wedatasphere.dss.apiservice.core.bo.ApiServiceQuery;
 import com.webank.wedatasphere.dss.apiservice.core.service.ApiService;
 import com.webank.wedatasphere.dss.apiservice.core.service.ApiServiceQueryService;
@@ -455,8 +456,9 @@ public Message apiDelete(@RequestParam(required = false, name = "id") Long id,
 
     @RequestMapping(value = "/apiCommentUpdate",method = RequestMethod.POST)
     public Message apiCommentUpdate(@Context HttpServletRequest req,
-                                    @RequestParam(required = false, name = "id") Long id,
-                                    @RequestParam(required = false, name = "comment") String comment) {
+                                    @RequestBody ApiCommentUpdateRequest apiCommentUpdateRequest) {
+        Long id = apiCommentUpdateRequest.getId();
+        String comment = apiCommentUpdateRequest.getComment();
         //目前暂时不实际删除数据，只做不可见和不可用。
         return ApiUtils.doAndResponse(() -> {
             String userName = SecurityFilter.getLoginUsername(req);

dss-framework/dss-framework-workspace-server/src/main/java/com/webank/wedatasphere/dss/framework/workspace/bean/request/AddFavoriteRequest.java

@@ -0,0 +1,15 @@
+package com.webank.wedatasphere.dss.framework.workspace.bean.request;
+
+import java.io.Serializable;
+
+public class AddFavoriteRequest implements Serializable {
+   private Long menuApplicationId;
+
+    public Long getMenuApplicationId() {
+        return menuApplicationId;
+    }
+
+    public void setMenuApplicationId(Long menuApplicationId) {
+        this.menuApplicationId = menuApplicationId;
+    }
+}

dss-framework/dss-framework-workspace-server/src/main/java/com/webank/wedatasphere/dss/framework/workspace/bean/request/AddWorkspaceRequest.java

@@ -0,0 +1,42 @@
+package com.webank.wedatasphere.dss.framework.workspace.bean.request;
+
+import java.io.Serializable;
+
+public class AddWorkspaceRequest implements Serializable {
+    private String name;
+    private String department;
+    private String label;
+    private String description;
+
+    public String getName() {
+        return name;
+    }
+
+    public void setName(String name) {
+        this.name = name;
+    }
+
+    public String getDepartment() {
+        return department;
+    }
+
+    public void setDepartment(String department) {
+        this.department = department;
+    }
+
+    public String getLabel() {
+        return label;
+    }
+
+    public void setLabel(String label) {
+        this.label = label;
+    }
+
+    public String getDescription() {
+        return description;
+    }
+
+    public void setDescription(String description) {
+        this.description = description;
+    }
+}

dss-framework/dss-framework-workspace-server/src/main/java/com/webank/wedatasphere/dss/framework/workspace/restful/WorkspaceRestfulApi.java

@@ -21,6 +21,8 @@
 import com.webank.wedatasphere.dss.framework.workspace.bean.dto.response.HomepageVideoVo;
 import com.webank.wedatasphere.dss.framework.workspace.bean.dto.response.OnestopMenuVo;
 import com.webank.wedatasphere.dss.framework.workspace.bean.dto.response.WorkspaceFavoriteVo;
+import com.webank.wedatasphere.dss.framework.workspace.bean.request.AddFavoriteRequest;
+import com.webank.wedatasphere.dss.framework.workspace.bean.request.AddWorkspaceRequest;
 import com.webank.wedatasphere.dss.framework.workspace.bean.vo.DepartmentVO;
 import com.webank.wedatasphere.dss.framework.workspace.service.DSSWorkspaceService;
 import org.apache.linkis.common.exception.ErrorException;
@@ -70,14 +72,15 @@ public Message getUsernameExistence(@Context HttpServletRequest req, @RequestPar
         return Message.ok().data("workspaceNameExists", exists);
     }
 
-    @RequestMapping(path ="/workspaces", method = RequestMethod.POST)
+    @RequestMapping(path = "/workspaces", method = RequestMethod.POST)
     public Message addWorkspace(@Context HttpServletRequest req,
-                                @RequestParam(required = false, name = "name")String name ,
-                                @RequestParam(required = false, name = "department") String department,
-                                @RequestParam(required = false, name = "label") String label,
-                                @RequestParam(required = false, name = "description") String description) throws ErrorException {
+                                @RequestBody AddWorkspaceRequest addWorkspaceRequest) throws ErrorException {
+        String name = addWorkspaceRequest.getName();
+        String department = addWorkspaceRequest.getDepartment();
+        String label = addWorkspaceRequest.getLabel();
+        String description = addWorkspaceRequest.getDescription();
         String userName = SecurityFilter.getLoginUsername(req);
-        if (!dssWorkspaceService.checkAdmin(userName)){
+        if (!dssWorkspaceService.checkAdmin(userName)) {
             return Message.error("您好，您不是管理员,没有权限建立工作空间");
         }
         if (dssWorkspaceService.existWorkspaceName(name)) {
@@ -140,9 +143,9 @@ public Message getWorkspaceFavorites(@Context HttpServletRequest req, @PathVaria
      */
     @RequestMapping(path ="/workspaces/{workspaceId}/favorites", method = RequestMethod.POST)
     public Message addFavorite(@Context HttpServletRequest req, @PathVariable("workspaceId") Long workspaceId,
-                               @RequestParam(required = false, name = "menuApplicationId") Long menuApplicationId) {
+                               @RequestBody AddFavoriteRequest addFavoriteRequest) {
         String username = SecurityFilter.getLoginUsername(req);
-        Long favoriteId = dssWorkspaceService.addFavorite(username, workspaceId, menuApplicationId);
+        Long favoriteId = dssWorkspaceService.addFavorite(username, workspaceId, addFavoriteRequest.getMenuApplicationId());
         return Message.ok().data("favoriteId", favoriteId);
     }