Remove expose_constructor (#148)

Author: Trey2k

doc_classes/LuaAPI.xml

@@ -41,14 +41,6 @@
 				Loads a string with luaL_loadstring() and executes the top of the stack. Returns any errors.
 			</description>
 		</method>
-		<method name="expose_constructor">
-			<return type="LuaError" />
-			<param index="0" name="LuaConstructorName" type="String" />
-			<param index="1" name="Object" type="Object" />
-			<description>
-				Accepts any object that has a new() method. Allows lua to call the constructor aka the new() method. Exposed as a global with the given name.
-			</description>
-		</method>
 		<method name="function_exists">
 			<return type="bool" />
 			<param index="0" name="LuaFunctionName" type="String" />

project/testing/tests/LuaAPI.expose_constructor.gd

@@ -13,15 +13,15 @@ func _ready():
 
 	lua = LuaAPI.new()
 	lua.permissive = true
-	var err = lua.expose_constructor("TestObj", TestObject)
+	var err = lua.push_variant("TestObj", TestObject.new)
 	if err is LuaError:
 		errors.append(err)
 		fail()
 
 	# testName and testDescription are for any needed context about the test.
 	testName = "LuaAPI.expose_constructor"
 	testDescription = "
-Test LuaAPI.expose_constructor.
+Test LuaAPI.push_variant with a object constructor.
 Exoposes a object constructor for TestObject which contains one variable. A string
 lua calls the constructor and then sets the string to 'Hello from lua!'.
 We also test pulling it back to GD and confirm the contents of the string.

src/classes/luaAPI.cpp

@@ -30,7 +30,6 @@ void LuaAPI::_bind_methods() {
 	ClassDB::bind_method(D_METHOD("get_memory_usage"), &LuaAPI::getMemoryUsage);
 	ClassDB::bind_method(D_METHOD("push_variant", "Name", "var"), &LuaAPI::pushGlobalVariant);
 	ClassDB::bind_method(D_METHOD("pull_variant", "Name"), &LuaAPI::pullVariant);
-	ClassDB::bind_method(D_METHOD("expose_constructor", "LuaConstructorName", "Object"), &LuaAPI::exposeObjectConstructor);
 	ClassDB::bind_method(D_METHOD("call_function", "LuaFunctionName", "Args"), &LuaAPI::callFunction);
 	ClassDB::bind_method(D_METHOD("call_function_ref", "Args", "LuaFunctionRef"), &LuaAPI::callFunctionRef);
 	ClassDB::bind_method(D_METHOD("function_exists", "LuaFunctionName"), &LuaAPI::luaFunctionExists);
@@ -140,11 +139,6 @@ LuaError *LuaAPI::pushGlobalVariant(String name, Variant var) {
 	return state.pushGlobalVariant(name, var);
 }
 
-// Calls LuaState::exposeObjectConstructor()
-LuaError *LuaAPI::exposeObjectConstructor(String name, Object *obj) {
-	return state.exposeObjectConstructor(name, obj);
-}
-
 // addFile() calls luaL_loadfille with the absolute file path
 LuaError *LuaAPI::doFile(String fileName) {
 	// push the error handler onto the stack

src/classes/luaAPI.h

@@ -50,7 +50,6 @@ class LuaAPI : public RefCounted {
 	LuaError *doFile(String fileName);
 	LuaError *doString(String code);
 	LuaError *pushGlobalVariant(String name, Variant var);
-	LuaError *exposeObjectConstructor(String name, Object *obj);
 
 	Ref<LuaCoroutine> newCoroutine();
 	Ref<LuaCoroutine> getRunningCoroutine();

src/luaState.h

@@ -31,7 +31,6 @@ class LuaState {
 
 	LuaError *pushVariant(Variant var) const;
 	LuaError *pushGlobalVariant(String name, Variant var);
-	LuaError *exposeObjectConstructor(String name, Object *obj);
 	LuaError *handleError(int lua_error) const;
 
 	static LuaAPI *getAPI(lua_State *state);

src/metatables.cpp

@@ -22,32 +22,6 @@
 	lua_pushcfunction(lua_state, LUA_LAMBDA_TEMPLATE(_f_));                       \
 	lua_settable(lua_state, metatable_index - 2);
 
-// Expose the constructor for a object to lua
-LuaError *LuaState::exposeObjectConstructor(String name, Object *obj) {
-	// Make sure we are able to call new
-	if (!obj->has_method("new")) {
-		return LuaError::newError("during \"LuaState::exposeObjectConstructor\" method 'new' does not exist.", LuaError::ERR_RUNTIME);
-	}
-	lua_pushlightuserdata(L, obj);
-
-	lua_pushcclosure(L, LUA_LAMBDA_TEMPLATE({
-		Object *inner_obj = (Object *)lua_touserdata(inner_state, lua_upvalueindex(1));
-
-		Variant *userdata = (Variant *)lua_newuserdata(inner_state, sizeof(Variant));
-		Variant ret = inner_obj->call("new");
-
-		memnew_placement(userdata, Variant(ret));
-
-		luaL_setmetatable(inner_state, "mt_Object");
-
-		return 1;
-	}),
-			1);
-
-	lua_setglobal(L, name.ascii().get_data());
-	return nullptr;
-}
-
 // Expose the default constructors
 void LuaState::exposeConstructors() {
 	lua_pushcfunction(L, LUA_LAMBDA_TEMPLATE({