Skip to content

Commit 5500e88

Browse files
Newsletter componnet adjustment, improving accessibility score
1 parent 3bf63f5 commit 5500e88

File tree

9 files changed

+83
-35
lines changed

9 files changed

+83
-35
lines changed

components/layout/Footer.js

Lines changed: 21 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ export default function Footer() {
1616
src='/images/svg/logo.svg'
1717
height={250}
1818
width={250}
19-
alt='Logo'
19+
alt='Our footer logo'
2020
/>
2121
</a>
2222
</Link>
@@ -34,20 +34,26 @@ export default function Footer() {
3434
</nav>
3535
<div className={footerStyles.footer__socialIcons}>
3636
<ul className={footerStyles.footer__socialList}>
37-
{linksSocial.filter(link => link.isVisible).map(link => (
38-
<li className={footerStyles.footer__socialItem} key={link.text}>
39-
<Link href={link.href}>
40-
<a title={link.text} target='_blank'>
41-
<Image
42-
href={link.href}
43-
src={link.src}
44-
height={65}
45-
width={47}
46-
/>
47-
</a>
48-
</Link>
49-
</li>
50-
))}
37+
{linksSocial
38+
.filter(link => link.isVisible)
39+
.map(link => (
40+
<li
41+
className={footerStyles.footer__socialItem}
42+
key={link.text}
43+
>
44+
<Link href={link.href}>
45+
<a title={link.text} target='_blank'>
46+
<Image
47+
href={link.href}
48+
src={link.src}
49+
height={65}
50+
width={47}
51+
alt={link.alt}
52+
/>
53+
</a>
54+
</Link>
55+
</li>
56+
))}
5157
</ul>
5258
</div>
5359
</div>

components/mailchimp/NewsletterForm.js

Lines changed: 21 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import { createRef, useState } from 'react';
2+
import Image from 'next/image';
23
import { decode } from 'html-entities';
34
import Container from '@/components/containers/Container';
45
import newsletterStyles from '@/styles/Newsletter.module.scss';
@@ -114,9 +115,18 @@ const NewsletterForm = ({ status, message, onValidated }) => {
114115
return (
115116
<section className={newsletterStyles.newsletter}>
116117
<Container className={newsletterStyles.newsletter__inner}>
117-
<h4 className={newsletterStyles.newsletter__title}>
118-
Sign up for news &#62;
119-
</h4>
118+
<h2 className={newsletterStyles.newsletter__title}>
119+
Sign up for news
120+
<span className={newsletterStyles.newsletter__right_chevron}>
121+
<Image
122+
src='/images/svg/right-chevron.svg'
123+
height={18}
124+
width={18}
125+
alt='Right Chevron SVG'
126+
className={newsletterStyles.newsletter__right_chevron_image}
127+
/>
128+
</span>
129+
</h2>
120130
<div>
121131
<form
122132
className={newsletterStyles.newsletter__form}
@@ -125,30 +135,30 @@ const NewsletterForm = ({ status, message, onValidated }) => {
125135
<input
126136
className={`${newsletterStyles.newsletter__input} ${newsletterStyles.newsletter__name}`}
127137
onChange={event => setName(event?.target?.value ?? '')}
128-
type="text"
129-
name="name"
138+
type='text'
139+
name='name'
130140
value={name}
131-
placeholder="name"
141+
placeholder='name'
132142
/>
133143
<input
134144
className={`${newsletterStyles.newsletter__input} ${newsletterStyles.newsletter__email}`}
135145
onChange={event => setEmail(event?.target?.value ?? '')}
136-
type="email"
137-
name="email"
146+
type='email'
147+
name='email'
138148
value={email}
139-
placeholder="email"
149+
placeholder='email'
140150
onKeyUp={event => handleInputKeyEvent(event)}
141151
/>
142152
<button
143153
className={newsletterStyles.newsletter__button}
144-
type="submit"
154+
type='submit'
145155
>
146156
Subscribe
147157
</button>
148158

149159
<ReCAPTCHA
150160
ref={recaptchaRef}
151-
size="invisible"
161+
size='invisible'
152162
sitekey={SITE_KEY}
153163
onChange={onReCAPTCHAChange}
154164
/>

next.config.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,4 +7,8 @@ module.exports = withPWA({
77
skipWaiting: true,
88
disable: process.env.NODE_ENV === 'development',
99
},
10+
i18n: {
11+
locales: ['en'],
12+
defaultLocale: 'en',
13+
},
1014
});

pages/index.js

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ export default function Home() {
1313
<TwoColumn
1414
title="Let's grow together."
1515
image='/images/join-us.webp'
16-
altTag='Join us'
16+
altTag='Join the project'
1717
content='The Web Dev Path is a team of professional developers project that aims to provide a comprehensive path for people who seek to begin their web development journey.'
1818
link='/about'
1919
customBtnClass='inverted-grey'
@@ -33,13 +33,21 @@ export default function Home() {
3333

3434
<RevealContentContainer>
3535
<CardsColumns
36-
titles={['Join us', 'Volunteer', 'Become a mentor']}
36+
titles={[
37+
'Join the project',
38+
'Volunteer to learn together',
39+
'Become a project mentor',
40+
]}
3741
images={[
3842
'/images/join-us.webp',
3943
'/images/volunteer.webp',
4044
'/images/mentor.webp',
4145
]}
42-
altTags={['Join us', 'Volunteer', 'Become a mentor']}
46+
altTags={[
47+
'Join the project',
48+
'Volunteer to learn together',
49+
'Become a project mentor',
50+
]}
4351
content={[
4452
'Are you learning web development and need mentorship? Are you a web dev looking for help or a code buddy for a project? ',
4553
'Would you like to volunteer? For roles other than mentor/mentee, please get in touch.',

public/images/svg/iconmonstr-github.svg

Lines changed: 0 additions & 1 deletion
This file was deleted.

public/images/svg/iconmonstr-twitter.svg

Lines changed: 0 additions & 1 deletion
This file was deleted.

public/images/svg/right-chevron.svg

Lines changed: 3 additions & 0 deletions
Loading

styles/Newsletter.module.scss

Lines changed: 20 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,13 +40,32 @@
4040
color: $primary-content-color;
4141
margin: 0;
4242
white-space: nowrap;
43+
display:flex;
44+
gap: 0.5rem;
4345

4446
@include medium-desktop {
4547
font-size: 1.75rem;
48+
gap: 1rem;
4649
}
4750

4851
@include large-desktop {
4952
font-size: 2.25rem;
53+
gap: 1.5rem;
54+
}
55+
}
56+
57+
&__right_chevron{
58+
position: relative;
59+
top: 0.1rem;
60+
61+
@include large-desktop {
62+
top: unset;
63+
64+
img {
65+
width: 1.5rem !important;
66+
height: 1.5rem !important;
67+
}
68+
5069
}
5170
}
5271

@@ -55,9 +74,6 @@
5574
display: flex;
5675
align-items: center;
5776
gap: 1rem;
58-
}
59-
60-
@include desktop {
6177
margin-left: auto;
6278
}
6379
}
@@ -69,7 +85,7 @@
6985
height: 2rem;
7086
margin: 1rem 0;
7187
padding: 1rem 1.25rem;
72-
border: none;
88+
border: 1px solid $dark-bg-color;
7389
width: 100%;
7490

7591
@include large-desktop {

utils/links.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,20 +15,23 @@ export const linksSocial = [
1515
text: 'LinkedIn',
1616
href: '#',
1717
src: '/images/svg/LinkedIn.svg',
18+
alt: 'Find us on LinkedIn',
1819
isVisible: false,
1920
},
2021
{
2122
id: 2,
2223
text: 'YouTube',
2324
href: 'https://www.youtube.com/channel/UCCLwmU7r4IUWZOtH3bCEN6g',
2425
src: '/images/svg/YouTube.svg',
26+
alt: 'Find us on YouTube',
2527
isVisible: true,
2628
},
2729
{
2830
id: 3,
2931
text: 'GitHub',
3032
href: 'https://github.com/Web-Dev-Path',
3133
src: '/images/svg/GitHub.svg',
34+
alt: 'Find us on GitHub',
3235
isVisible: true,
3336
},
3437
];

0 commit comments

Comments
 (0)