Skip to content

Commit 58ef6ae

Browse files
authored
Merge branch 'main' into feature/husky-precommit
2 parents 9e60eff + 6109b8f commit 58ef6ae

File tree

8 files changed

+256
-15
lines changed

8 files changed

+256
-15
lines changed
Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
---
2+
name: Web Dev Path issue
3+
about: Describe this issue template's purpose here.
4+
title: ''
5+
labels: help wanted
6+
assignees: ''
7+
8+
---
9+
10+
**What do we need to build or fix?**
11+
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
12+
13+
**Technical details**
14+
A clear and concise description of what you want to happen.
15+
16+
**Approach suggestions**
17+
A clear and concise description of any alternative solutions or features you've considered.
18+
19+
**Deadline**
20+
Please keep in mind that once you assign this task to yourself, you'll need to complete it in 10 days.
21+
22+
**Acceptance criteria**
23+
- Test the section and components in many screen sizes, you can use the Inspect tool for that.
24+
- Please test if the new changes added to the components do not affect the other instances.
25+
- Test the feature in many browsers, such as Chrome, Firefox, Edge, and Safari (MAC).
26+
- Update the CHANGELOG.md file.

CHANGELOG.md

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
4646

4747
- Made the site a Progressive Web App (PWA)
4848
- About page content (first section)
49+
- About page "Wanna Learn More" and "How to get started?" section
50+
- An optional second column to TwoColumn instead of the image
4951
- .prettierignore file
5052
- husky, lint-staged to auto format with prettier on git commit
5153
- lint and format script to run prettier check and write on all files respectively
@@ -63,4 +65,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
6365
- updated 'about us' first section (our background, peer reviews, version control)
6466
- updated 'about us' section (our goals, our purpose)
6567
- updated mobile nav to automatically close when page route change is completed
66-
- prettierrc "end of line" to auto
68+
- adjust flex-basis of a few sections in the about page to better match the design file
69+
- prettierrc "end of line" to auto
70+
71+
72+

components/buttons/ButtonLink.js

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,24 @@
1-
import Link from 'next/link';
21
import btnStyles from '@/styles/ButtonLink.module.scss';
32

3+
/* The component supports the use of target with the property "openNewTab" to open the
4+
link in a new tab.*/
5+
46
export default function ButtonLink({
57
customClassName,
68
link,
79
children,
810
styles,
11+
openNewTab,
912
}) {
1013
return (
11-
<Link href={link}>
12-
<a
13-
className={`${btnStyles.btn} ${btnStyles[customClassName]}`}
14-
style={styles}
15-
>
16-
{children}
17-
</a>
18-
</Link>
14+
<a
15+
href={link}
16+
className={customClassName?`${btnStyles.btn} ${btnStyles[customClassName]}`:btnStyles.btn}
17+
style={styles}
18+
target={openNewTab ? '_blank' : undefined}
19+
rel='noopener noreferrer'
20+
>
21+
{children}
22+
</a>
1923
);
2024
}

components/containers/TwoColumn.js

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,8 @@ export default function TwoColumn({
1515
customInnerClass,
1616
customBtnClass,
1717
linkText = 'Learn more',
18+
secondTextColumn,
19+
openNewTab,
1820
}) {
1921
// Add rowOrder="row-reverse" prop to the component to reverse its order on desktop
2022

@@ -43,19 +45,23 @@ export default function TwoColumn({
4345
)}
4446
<div className={styles.content}>{content}</div>
4547
{link && (
46-
<ButtonLink link={link} customClassName={customBtnClass}>
48+
<ButtonLink
49+
link={link}
50+
customClassName={customBtnClass}
51+
openNewTab={openNewTab}
52+
>
4753
{linkText}
4854
</ButtonLink>
4955
)}
5056
</div>
51-
{image && (
57+
{secondTextColumn && secondTextColumn}
58+
{!secondTextColumn && image && (
5259
<div className={styles.inner__image}>
5360
<Image
5461
src={image}
5562
alt={altTag}
5663
className={styles.img}
5764
layout='fill'
58-
priority
5965
/>
6066
</div>
6167
)}

pages/about.js

Lines changed: 78 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,11 @@
11
import RevealContentContainer from '@/components/containers/RevealContentContainer';
22
import TwoColumn from '@/components/containers/TwoColumn';
3-
import { white, primary, primaryAccent } from '@/styles/TwoColumn.module.scss';
3+
import {
4+
white,
5+
primary,
6+
primaryAccent,
7+
lightBgColor,
8+
} from '@/styles/TwoColumn.module.scss';
49
import CardsColumns from '@/components/containers/CardsColumns';
510
import Title from '@/components/snippets/Title';
611
import Container from '@/components/containers/Container';
@@ -127,6 +132,78 @@ export default function AboutUs() {
127132
customInnerClass='our-purpose'
128133
/>
129134
</RevealContentContainer>
135+
<RevealContentContainer>
136+
<TwoColumn
137+
title='Wanna learn more?'
138+
content={''}
139+
image='/images/svg/close-curly-bracket.svg'
140+
color={primary}
141+
bgColor={lightBgColor}
142+
customInnerClass='wanna-learn-more'
143+
/>
144+
<TwoColumn
145+
title="Junior Developers"
146+
content={
147+
'If you are a junior web developer looking for some guidance and mentoring, ' +
148+
'we invite you to join us and start coding our platform. ' +
149+
"You will learn how to code in a team environment by following issue's " +
150+
'instructions and submitting your code to our repository through a ' +
151+
'PR while guided throughout the entire process.\n'
152+
}
153+
linkText='Our wiki'
154+
openNewTab
155+
link='https://github.com/Web-Dev-Path/web-dev-path/wiki'
156+
customBtnClass='inverted-grey'
157+
color={primary}
158+
bgColor={lightBgColor}
159+
customInnerClass='two-text-columns'
160+
secondTextColumn={
161+
<TwoColumn
162+
title="Experienced Developers"
163+
content={
164+
'If you are an experienced and patient-loving developer, ' +
165+
'a true rockstar who wants to mentor juniors, ' +
166+
"it will be wonderful to have your help to review those PR's, " +
167+
'write detailed issues and guide the developers when necessary.\n'
168+
}
169+
linkText='Contact us'
170+
link='/contact'
171+
customBtnClass='inverted-grey'
172+
color={primary}
173+
bgColor={lightBgColor}
174+
customInnerClass='second-text-column'
175+
/>
176+
}
177+
/>
178+
</RevealContentContainer>
179+
<RevealContentContainer>
180+
<TwoColumn
181+
title='How to get started?'
182+
content={
183+
<div>
184+
After taking a look at our project&nbsp;
185+
<a target='_blank'
186+
href='https://github.com/Web-Dev-Path/web-dev-path#readme'
187+
rel='noopener noreferrer' >README</a> and&nbsp;
188+
<a target='_blank'
189+
href='https://github.com/Web-Dev-Path/web-dev-path/wiki'
190+
rel='noopener noreferrer' >wiki</a>,
191+
just send us an email sharing with us about your journey in tech and
192+
why you’re interested in joining us.
193+
<br/>
194+
We've got you!
195+
</div>
196+
}
197+
rowOrder='row-reverse'
198+
image='/images/svg/slash.svg'
199+
color={primary}
200+
bgColor={white}
201+
customInnerClass='get-started'
202+
link="mailto:[email protected]"
203+
linkText="Ping Us"
204+
customBtnClass='inverted-grey'
205+
/>
206+
</RevealContentContainer>
130207
</div>
131208
);
132209
}
Lines changed: 3 additions & 0 deletions
Loading

public/images/svg/slash.svg

Lines changed: 3 additions & 0 deletions
Loading

styles/TwoColumn.module.scss

Lines changed: 117 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
@use './mixins' as *;
33

44
.wrapper {
5+
align-self: stretch;
6+
57
.inner {
68
padding: 5rem 0;
79
margin: 0 auto;
@@ -20,13 +22,15 @@
2022
color: $primary-content-color;
2123
margin: 0;
2224
}
25+
2326
.content {
2427
display: flex;
2528
align-items: center;
2629
margin: 3.875rem 0 2.5rem;
2730
max-width: 39rem;
2831
font-size: 1.5rem;
2932
line-height: 1.938rem;
33+
3034
a {
3135
text-decoration: underline;
3236
text-underline-offset: 2px;
@@ -84,9 +88,18 @@
8488
}
8589
}
8690

87-
&.about-content {
91+
&.about-content, &.get-started {
92+
.content{
93+
max-width: 49rem;
94+
}
95+
96+
.inner__content{
97+
flex-basis: 65%;
98+
}
99+
88100
.inner__image {
89101
height: 10rem;
102+
flex-basis: 25%;
90103

91104
@include desktop {
92105
height: 15rem;
@@ -100,8 +113,13 @@
100113
}
101114

102115
&.our-purpose {
116+
.inner__content{
117+
flex-basis: 65%;
118+
}
119+
103120
.inner__image {
104121
height: 10rem;
122+
flex-basis: 25%;
105123

106124
@include desktop {
107125
height: 22rem;
@@ -113,6 +131,102 @@
113131
}
114132
}
115133

134+
&.wanna-learn-more {
135+
.content {
136+
margin: 0;
137+
}
138+
139+
.inner__content {
140+
flex-basis: 70%;
141+
}
142+
143+
.inner__image {
144+
height: 10rem;
145+
flex-basis: 30%;
146+
147+
@include desktop {
148+
height: 20rem;
149+
}
150+
151+
.img {
152+
object-fit: contain;
153+
}
154+
}
155+
}
156+
157+
&.two-text-columns {
158+
justify-content: space-evenly;
159+
160+
.inner {
161+
padding: 0px;
162+
margin: 0px;
163+
}
164+
165+
.inner__content {
166+
display: flex;
167+
flex-direction: column;
168+
align-items: flex-start;
169+
}
170+
171+
h2 {
172+
font-size: 2rem;
173+
line-height: 2.5rem;
174+
}
175+
176+
.inner {
177+
margin: 0px;
178+
padding: 0px;
179+
}
180+
181+
.inner__content {
182+
flex-basis: unset;
183+
184+
@include desktop {
185+
width: 25rem;
186+
}
187+
}
188+
189+
a {
190+
margin-top: auto;
191+
color: $light-bg-color;
192+
}
193+
194+
a:hover {
195+
color: $primary-content-color;
196+
}
197+
}
198+
199+
&.second-text-column {
200+
height: 100%;
201+
width: 100%;
202+
203+
.inner {
204+
height: 100%;
205+
}
206+
207+
.inner__content {
208+
height: 100%;
209+
}
210+
}
211+
212+
&.get-started {
213+
padding-bottom: 0px;
214+
.inner__image{
215+
display: none;
216+
217+
@include desktop {
218+
display: unset;
219+
}
220+
}
221+
222+
@include desktop {
223+
padding-bottom: 5rem;
224+
}
225+
226+
227+
228+
}
229+
116230
@include desktop {
117231
display: flex;
118232
align-items: center;
@@ -122,6 +236,8 @@
122236
}
123237
}
124238

239+
240+
125241
//Exports
126242
:export {
127243
white: $white;

0 commit comments

Comments
 (0)