Skip to content

Commit 5c9902c

Browse files
committed
separate SubmitButton & NewsletterSubmitButton
remove all props in SubmitButton.js extended SubmitButton styled component to make NewsLetterSubmitButton
1 parent 60bb1cf commit 5c9902c

File tree

4 files changed

+26
-28
lines changed

4 files changed

+26
-28
lines changed

components/ContactUsForm/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import MailchimpSubscribe from 'react-mailchimp-subscribe';
44
import ReCAPTCHA from 'react-google-recaptcha';
55
import Container from '@/components/containers/Container';
66
import RevealContentContainer from '@/components/containers/RevealContentContainer';
7-
import SubmitButton from '@/components/buttons/SubmitButton';
7+
import { SubmitButton } from '@/components/buttons/SubmitButton';
88
import S from './styles';
99

1010
export const ContactUsFormSubscribe = ({ setMsg }) => {
Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,17 @@
11
import S from './styles';
22

3-
export default function SubmitButton({ $buttonType, label, disabled }) {
3+
export function SubmitButton({ label, disabled }) {
44
return (
5-
<S.SubmitButton $buttonType={$buttonType} type='submit' disabled={disabled}>
5+
<S.SubmitButton type='submit' disabled={disabled}>
66
{label}
77
</S.SubmitButton>
88
);
99
}
10+
11+
export function NewsLetterSubmitButton({ label, disabled }) {
12+
return (
13+
<S.NewsLetterSubmitButton type='submit' disabled={disabled}>
14+
{label}
15+
</S.NewsLetterSubmitButton>
16+
);
17+
}

components/buttons/SubmitButton/styles.js

Lines changed: 13 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -32,26 +32,10 @@ const SubmitButton = styled.button`
3232
font-size: 1.5rem;
3333
min-width: 16rem;
3434
padding: 0.5rem 2rem;
35-
//check props for button variations
36-
${props =>
37-
props.$buttonType === 'newsletter__button' ? NewsLetterButton : ''}
3835
`)}
39-
40-
//media query mixins
41-
${m.largeDesktop(css`
42-
//check props for button variations
43-
${props =>
44-
props.$buttonType === 'newsletter__button'
45-
? NewsLetterButtonLgDesktop
46-
: ''}
47-
`)}
48-
49-
//check props for button variations
50-
${props =>
51-
props.$buttonType === 'newsletter__button' ? NewsLetterButton : ''}
5236
`;
5337

54-
const NewsLetterButton = css`
38+
const NewsLetterSubmitButton = styled(SubmitButton)`
5539
border-radius: 1.2rem;
5640
font-size: 1.2rem;
5741
background-color: ${$darkBgColor};
@@ -62,12 +46,18 @@ const NewsLetterButton = css`
6246
color: ${$darkBgColor};
6347
border: 1px solid #{$darkBgColor};
6448
}
65-
`;
6649
67-
const NewsLetterButtonLgDesktop = css`
68-
min-width: 12rem;
69-
border-radius: 3rem;
70-
padding: 0.7rem 0;
50+
${m.desktop(css`
51+
border-radius: 1.2rem;
52+
font-size: 1.2rem;
53+
padding: 0.3rem 0;
54+
`)}
55+
56+
${m.largeDesktop(css`
57+
min-width: 12rem;
58+
border-radius: 3rem;
59+
padding: 0.7rem 0;
60+
`)}
7161
`;
7262

73-
export default { SubmitButton };
63+
export default { SubmitButton, NewsLetterSubmitButton };

components/mailchimp/NewsletterForm/index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import Image from 'next/image';
33
import { decode } from 'html-entities';
44
import ReCAPTCHA from 'react-google-recaptcha';
55
import Container from '@/components/containers/Container';
6-
import SubmitButton from '@/components/buttons/SubmitButton';
6+
import { NewsLetterSubmitButton } from '@/components/buttons/SubmitButton';
77
import S from './styles';
88

99
const SITE_KEY = process.env.NEXT_PUBLIC_RECAPTCHA_SITE_KEY;
@@ -144,7 +144,7 @@ const NewsletterForm = ({ status, message, onValidated }) => {
144144
placeholder='email'
145145
onKeyUp={event => handleInputKeyEvent(event)}
146146
/>
147-
<SubmitButton label='Subscribe' $buttonType='newsletter__button' />
147+
<NewsLetterSubmitButton label='Subscribe' />
148148

149149
<ReCAPTCHA
150150
ref={recaptchaRef}

0 commit comments

Comments
 (0)