Skip to content

Commit 6636994

Browse files
Merge pull request #143 from Web-Dev-Path/feature/still-got-questions
Add Still got questions section to about page
2 parents f8dd186 + e07bd41 commit 6636994

File tree

9 files changed

+64
-53
lines changed

9 files changed

+64
-53
lines changed

.github/ISSUE_TEMPLATE/web-dev-path-issue.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ about: Describe this issue template's purpose here.
44
title: ''
55
labels: help wanted
66
assignees: ''
7-
87
---
98

109
**What do we need to build or fix?**
@@ -20,8 +19,9 @@ A clear and concise description of any alternative solutions or features you've
2019
Please keep in mind that once you assign this task to yourself, you'll need to complete it in 10 days.
2120

2221
**Acceptance criteria**
22+
2323
- Test the section and components in many screen sizes, you can use the Inspect tool for that.
2424
- Please test if the new changes added to the components do not affect the other instances.
2525
- Test the feature in many browsers, such as Chrome, Firefox, Edge, and Safari (MAC).
26-
- If there are any build problems when submitting your PR, run yarn build locally to solve the issues and commit the changes.
26+
- If there are any build problems when submitting your PR, run `yarn build` locally to solve the issues and commit the changes.
2727
- Update the CHANGELOG.md file.
File renamed without changes.

CHANGELOG.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
5151
- .prettierignore file
5252
- husky, lint-staged to auto format with prettier on git commit
5353
- lint and format script to run prettier check and write on all files respectively
54-
- who we are components
54+
- who we are section to about page
55+
- still got questions section to about page
5556

5657
### Fixed
5758

components/containers/Member.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ export default function Member({
2626
{linkedIn && (
2727
<div className={`${styles.links}`}>
2828
<Image
29-
src='/images/svg/LinkedIn2.svg'
29+
src='/images/svg/linkedin-portfolio.svg'
3030
alt='LinkedIn'
3131
height='25px'
3232
width='25px'

pages/about.js

Lines changed: 16 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ export default function AboutUs() {
7777
image='/images/svg/open-angle-bracket.svg'
7878
color={primary}
7979
bgColor={white}
80-
customInnerClass='about-content'
80+
customInnerClass='our-process'
8181
/>
8282
<TwoColumn
8383
title='Version control'
@@ -98,7 +98,7 @@ export default function AboutUs() {
9898
image='/images/svg/close-angle-bracket.svg'
9999
color={primary}
100100
bgColor={white}
101-
customInnerClass='about-content'
101+
customInnerClass='our-process'
102102
/>
103103
</RevealContentContainer>
104104
<RevealContentContainer>
@@ -214,7 +214,7 @@ export default function AboutUs() {
214214
bgColor={white}
215215
customInnerClass='get-started'
216216
link='mailto:[email protected]'
217-
linkText='Ping Us'
217+
linkText='Ping us'
218218
customBtnClass='inverted-grey'
219219
/>
220220
</RevealContentContainer>
@@ -241,6 +241,19 @@ export default function AboutUs() {
241241
</Container>
242242
</Wrapper>
243243
</RevealContentContainer>
244+
<RevealContentContainer>
245+
<TwoColumn
246+
title='Still got questions?'
247+
content='Feel free to contact us.'
248+
image='/images/svg/hashtag.svg'
249+
color={primary}
250+
bgColor={white}
251+
customInnerClass='questions'
252+
link='/contact'
253+
linkText='Contact us'
254+
customBtnClass='inverted-grey'
255+
/>
256+
</RevealContentContainer>
244257
</div>
245258
);
246259
}

public/images/svg/hashtag.svg

Lines changed: 4 additions & 0 deletions
Loading

styles/TwoColumn.module.scss

Lines changed: 36 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,7 @@
5959
}
6060

6161
// Homepage
62+
6263
&.get-involved {
6364
@include desktop-breakpoint-minus {
6465
padding-bottom: 0;
@@ -73,60 +74,59 @@
7374
}
7475
}
7576

76-
//About us
77-
&.our-background {
78-
.inner__image {
79-
height: 14rem;
77+
// end Homepage
8078

81-
@include desktop {
82-
height: 18rem;
83-
}
79+
//About page
8480

81+
&.our-process,
82+
&.get-started,
83+
&.our-purpose,
84+
&.our-background,
85+
&.questions {
86+
.inner__image {
87+
height: 10rem;
8588
.img {
8689
object-fit: contain;
8790
}
8891
}
8992
}
9093

91-
&.about-content, &.get-started {
92-
.content{
93-
max-width: 49rem;
94-
}
95-
96-
.inner__content{
97-
flex-basis: 65%;
98-
}
99-
94+
&.our-background {
10095
.inner__image {
101-
height: 10rem;
102-
flex-basis: 25%;
103-
10496
@include desktop {
10597
height: 15rem;
10698
}
99+
}
100+
}
107101

108-
.img {
109-
max-width: 14rem;
110-
object-fit: contain;
102+
&.our-process {
103+
.inner__image {
104+
@include desktop {
105+
height: 12rem;
111106
}
112107
}
113108
}
114109

115110
&.our-purpose {
116-
.inner__content{
117-
flex-basis: 65%;
111+
.inner__image {
112+
@include desktop {
113+
height: 18rem;
114+
}
118115
}
116+
}
119117

118+
&.get-started {
120119
.inner__image {
121-
height: 10rem;
122-
flex-basis: 25%;
123-
124120
@include desktop {
125-
height: 22rem;
121+
height: 20rem;
126122
}
123+
}
124+
}
127125

128-
.img {
129-
object-fit: contain;
126+
&.questions {
127+
.inner__image {
128+
@include desktop {
129+
height: 13rem;
130130
}
131131
}
132132
}
@@ -136,16 +136,11 @@
136136
margin: 0;
137137
}
138138

139-
.inner__content {
140-
flex-basis: 70%;
141-
}
142-
143139
.inner__image {
144140
height: 10rem;
145-
flex-basis: 30%;
146141

147142
@include desktop {
148-
height: 20rem;
143+
height: 15rem;
149144
}
150145

151146
.img {
@@ -209,9 +204,10 @@
209204
}
210205
}
211206

212-
&.get-started {
207+
&.get-started,
208+
&.questions {
213209
padding-bottom: 0px;
214-
.inner__image{
210+
.inner__image {
215211
display: none;
216212

217213
@include desktop {
@@ -222,11 +218,10 @@
222218
@include desktop {
223219
padding-bottom: 5rem;
224220
}
225-
226-
227-
228221
}
229222

223+
// end About page
224+
230225
@include desktop {
231226
display: flex;
232227
align-items: center;
@@ -236,8 +231,6 @@
236231
}
237232
}
238233

239-
240-
241234
//Exports
242235
:export {
243236
white: $white;

utils/links.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,23 +9,23 @@ export const linksSocial = [
99
id: 1,
1010
text: 'LinkedIn',
1111
href: '#',
12-
src: '/images/svg/LinkedIn.svg',
12+
src: '/images/svg/linkedin.svg',
1313
alt: 'Find us on LinkedIn',
1414
isVisible: false,
1515
},
1616
{
1717
id: 2,
1818
text: 'YouTube',
1919
href: 'https://www.youtube.com/channel/UCCLwmU7r4IUWZOtH3bCEN6g',
20-
src: '/images/svg/YouTube.svg',
20+
src: '/images/svg/youtube.svg',
2121
alt: 'Find us on YouTube',
2222
isVisible: true,
2323
},
2424
{
2525
id: 3,
2626
text: 'GitHub',
2727
href: 'https://github.com/Web-Dev-Path',
28-
src: '/images/svg/GitHub.svg',
28+
src: '/images/svg/github.svg',
2929
alt: 'Find us on GitHub',
3030
isVisible: true,
3131
},

0 commit comments

Comments
 (0)