Skip to content

Commit 86d4961

Browse files
committed
fix constructor params of auth connector
1 parent 9f282c2 commit 86d4961

File tree

2 files changed

+10
-3
lines changed

2 files changed

+10
-3
lines changed

packages/no-modal/src/base/core/IWeb3Auth.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,7 @@ export interface IWeb3AuthCoreOptions {
7575
*
7676
* @defaultValue "local"
7777
*/
78+
// TODO: rename this to match customauth, sfa
7879
storageType?: "session" | "local";
7980

8081
/**

packages/no-modal/src/connectors/auth-connector/authConnector.ts

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -124,6 +124,8 @@ class AuthConnector extends BaseConnector<AuthLoginParams> {
124124
});
125125
break;
126126
}
127+
case CHAIN_NAMESPACES.XRPL:
128+
throw WalletLoginError.connectionError("Private key provider is required for XRPL");
127129
default: {
128130
const { CommonPrivateKeyProvider } = await import("@/core/base-provider");
129131
this.privateKeyProvider = new CommonPrivateKeyProvider({
@@ -347,10 +349,10 @@ class AuthConnector extends BaseConnector<AuthLoginParams> {
347349
}
348350
}
349351

350-
export const authConnector = (params?: AuthConnectorOptions): ConnectorFn => {
352+
export const authConnector = (params?: Omit<AuthConnectorOptions, "coreOptions">): ConnectorFn => {
351353
return ({ projectConfig, coreOptions }: ConnectorParams) => {
352354
// Connector settings
353-
const connectorSettings: AuthConnectorOptions["connectorSettings"] = { uxMode: UX_MODE.POPUP };
355+
const connectorSettings: AuthConnectorOptions["connectorSettings"] = {};
354356
const { sms_otp_enabled: smsOtpEnabled, whitelist } = projectConfig;
355357
if (smsOtpEnabled !== undefined) {
356358
connectorSettings.loginConfig = {
@@ -367,7 +369,11 @@ export const authConnector = (params?: AuthConnectorOptions): ConnectorFn => {
367369
const uiConfig = deepmerge(cloneDeep(projectConfig?.whitelabel || {}), coreOptions.uiConfig || {});
368370
if (!uiConfig.mode) uiConfig.mode = "light";
369371
connectorSettings.whiteLabel = uiConfig;
370-
const finalConnectorSettings = deepmerge(params?.connectorSettings || {}, connectorSettings) as AuthConnectorOptions["connectorSettings"];
372+
const finalConnectorSettings = deepmerge.all([
373+
{ uxMode: UX_MODE.POPUP }, // default settings
374+
params?.connectorSettings || {},
375+
connectorSettings,
376+
]) as AuthConnectorOptions["connectorSettings"];
371377

372378
// WS settings
373379
const isKeyExportEnabled = typeof projectConfig.key_export_enabled === "boolean" ? projectConfig.key_export_enabled : true;

0 commit comments

Comments
 (0)