fix: set correct type of icon url passed to Metamask SDK

Author: tanguyenvn

packages/no-modal/src/connectors/metamask-connector/metamaskConnector.ts

@@ -84,7 +84,7 @@ class MetaMaskConnector extends BaseEvmConnector<void> {
     const appMetadata: MetaMaskSDKOptions["dappMetadata"] = {
       name: getSiteName(window) || "web3auth",
       url: window.location.origin || "https://web3auth.io",
-      iconUrl,
+      iconUrl: iconUrl ?? undefined,
     };
 
     // initialize the MetaMask SDK

packages/no-modal/src/connectors/utils.ts

@@ -44,7 +44,7 @@ function imgExists(url: string): Promise<boolean> {
 /**
  * Extracts an icon for the site from the DOM
  */
-export async function getSiteIcon(window: Window): Promise<string | null> {
+export async function getSiteIcon(window: Window): Promise<string | undefined> {
   const { document } = window;
 
   // Use the site's favicon if it exists
@@ -59,7 +59,7 @@ export async function getSiteIcon(window: Window): Promise<string | null> {
     return icon.href;
   }
 
-  return null;
+  return undefined;
 }
 
 export function parseToken<T>(token: string): { header: { alg: string; typ: string; kid?: string }; payload: T } {