Skip to content

Commit e964414

Browse files
author
Nguyen Anh Tu
committed
Merge commit 'c607e0da3f599330d54f7e3d35cb732ac8e31b35' into feat/sdk-v10
2 parents 14ee848 + c607e0d commit e964414

File tree

23 files changed

+300
-328
lines changed

23 files changed

+300
-328
lines changed

demo/vue-app-new2/package-lock.json

Lines changed: 5 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

demo/vue-app-new2/package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
"@toruslabs/vue-icons": "^7.6.2",
1818
"@web3auth/auth": "^9.6.4",
1919
"@web3auth/modal": "file:../../packages/modal",
20+
"@web3auth/no-modal": "file:../../packages/no-modal",
2021
"@web3auth/sign-in-with-ethereum": "^4.2.2",
2122
"@web3auth/ws-embed": "^3.4.4",
2223
"bs58": "^6.0.0",

demo/vue-app-new2/src/MainView.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import Web3 from "web3";
66
77
const ethereumChainConfig = getEvmChainConfig(Number("0x13882"))!;
88
const ethWeb3AuthOptions: Web3AuthOptions = {
9-
chainConfig: ethereumChainConfig,
9+
chainConfigs: [ethereumChainConfig],
1010
enableLogging: true,
1111
clientId: clientIds["mainnet"],
1212
web3AuthNetwork: "mainnet",

demo/vue-app-new2/src/components/AppSettings.vue

Lines changed: 1 addition & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ const onChainNamespaceChange = (value: string) => {
9494
<Card class="h-auto p-4 sm:p-8 col-span-8 sm:col-span-6 lg:col-span-4 max-sm:!shadow-none max-sm:!border-0">
9595
<div class="text-2xl font-bold leading-tight text-center sm:text-3xl">{{ $t("app.greeting") }}</div>
9696
<div class="my-4 font-extrabold leading-tight text-center">
97-
<Tag v-bind="{ minWidth: 'inherit' }" :class="['uppercase', { '!bg-blue-400 text-white': status.value === ADAPTER_STATUS.READY }]">
97+
<Tag v-bind="{ minWidth: 'inherit' }" :class="['uppercase', { '!bg-blue-400 text-white': status === ADAPTER_STATUS.READY }]">
9898
{{ status }}
9999
</Tag>
100100
&nbsp;
@@ -348,22 +348,6 @@ const onChainNamespaceChange = (value: string) => {
348348
:label-enabled="$t('app.walletPlugin.title')"
349349
class="mb-2"
350350
/>
351-
<TextField
352-
v-model="formData.walletPlugin.logoLight"
353-
:label="$t('app.walletPlugin.logoLight')"
354-
:disabled="isDisabled('walletServicePlugin')"
355-
:aria-label="$t('app.walletPlugin.logoLight')"
356-
:placeholder="$t('app.walletPlugin.logoLight')"
357-
class="sm:col-span-2"
358-
/>
359-
<TextField
360-
v-model="formData.walletPlugin.logoDark"
361-
:disabled="isDisabled('walletServicePlugin')"
362-
:label="$t('app.walletPlugin.logoDark')"
363-
:aria-label="$t('app.walletPlugin.logoDark')"
364-
:placeholder="$t('app.walletPlugin.logoDark')"
365-
class="sm:col-span-2"
366-
/>
367351
<Select
368352
v-model="formData.walletPlugin.confirmationStrategy"
369353
data-testid="selectLoginProviders"

packages/modal/src/modalManager.ts

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -85,11 +85,10 @@ export class Web3Auth extends Web3AuthNoModal implements IWeb3AuthModal {
8585
}
8686

8787
// initialize login modal
88-
const currentChainConfig = this.getCurrentChainConfig();
8988
this.loginModal = new LoginModal({
9089
...this.options.uiConfig,
9190
adapterListener: this,
92-
chainNamespace: currentChainConfig.chainNamespace,
91+
chainNamespace: this.currentChainConfig.chainNamespace,
9392
walletRegistry,
9493
});
9594
this.subscribeToLoginModalEvents();
@@ -121,9 +120,9 @@ export class Web3Auth extends Web3AuthNoModal implements IWeb3AuthModal {
121120
await this.loginModal.initModal();
122121

123122
// load default adapters: auth, injected wallets
124-
const adapterFns = await this.loadDefaultAdapters();
123+
const adapterFns = await this.loadDefaultAdapters({ projectConfig });
125124
adapterFns.map(async (adapterFn) => {
126-
const adapter = adapterFn({ projectConfig, options: this.coreOptions, getCurrentChainConfig: this.getCurrentChainConfig });
125+
const adapter = adapterFn({ projectConfig, coreOptions: this.coreOptions });
127126
if (this.walletAdapters[adapter.name]) return;
128127
this.walletAdapters[adapter.name] = adapter;
129128
});
@@ -199,7 +198,8 @@ export class Web3Auth extends Web3AuthNoModal implements IWeb3AuthModal {
199198
// if adapter is configured then only initialize in app or cached adapter.
200199
// external wallets are initialized on INIT_EXTERNAL_WALLET event.
201200
this.subscribeToAdapterEvents(connector);
202-
if (connector.status === ADAPTER_STATUS.NOT_READY) await connector.init({ autoConnect: this.cachedAdapter === adapterName });
201+
if (connector.status === ADAPTER_STATUS.NOT_READY)
202+
await connector.init({ autoConnect: this.cachedAdapter === adapterName, chainId: this.currentChainConfig.chainId });
203203
// note: not adding cachedWallet to modal if it is external wallet.
204204
// adding it later if no in-app wallets are available.
205205
if (connector.type === ADAPTER_CATEGORY.IN_APP) {
@@ -210,7 +210,7 @@ export class Web3Auth extends Web3AuthNoModal implements IWeb3AuthModal {
210210
}
211211
});
212212

213-
this.commonJRPCProvider = await CommonJRPCProvider.getProviderInstance({ chainConfig: this.getCurrentChainConfig() });
213+
this.commonJRPCProvider = await CommonJRPCProvider.getProviderInstance({ chainConfig: this.currentChainConfig });
214214
if (typeof keyExportEnabled === "boolean") {
215215
// dont know if we need to do this.
216216
this.commonJRPCProvider.setKeyExportFlag(keyExportEnabled);
@@ -276,7 +276,7 @@ export class Web3Auth extends Web3AuthNoModal implements IWeb3AuthModal {
276276
}
277277
if (adapter.status === ADAPTER_STATUS.NOT_READY) {
278278
await adapter
279-
.init({ autoConnect: this.cachedAdapter === adapterName })
279+
.init({ autoConnect: this.cachedAdapter === adapterName, chainId: this.currentChainConfig.chainId })
280280
.then<undefined>(() => {
281281
const adapterModalConfig = (this.modalConfig.adapters as Record<WALLET_ADAPTER_TYPE, ModalConfig>)[adapterName];
282282
adaptersConfig[adapterName] = { ...adapterModalConfig, isInjected: adapter.isInjected };
@@ -340,7 +340,7 @@ export class Web3Auth extends Web3AuthNoModal implements IWeb3AuthModal {
340340

341341
// refreshing session for wallet connect whenever modal is opened.
342342
try {
343-
adapter.connect();
343+
adapter.connect({ chainId: this.currentChainConfig.chainId });
344344
} catch (error) {
345345
log.error(`Error while disconnecting to wallet connect in core`, error);
346346
}

0 commit comments

Comments
 (0)