Define Flags in terms of integers

Remove the `Type::Flags` variant in favor of a witx-specific way to
define a bitflags with a number of constants.

Author: alexcrichton

phases/ephemeral/docs.md

@@ -282,14 +282,14 @@ Cross-device link.
 - <a href="#errno.notcapable" name="errno.notcapable"></a> `notcapable`
 Extension: Capabilities insufficient.
 
-## <a href="#rights" name="rights"></a> `rights`: Flags(`u64`)
+## <a href="#rights" name="rights"></a> `rights`: `u64`
 File descriptor rights, determining which actions may be performed.
 
 Size: 8
 
 Alignment: 8
 
-### Flags
+### Constants
 - <a href="#rights.fd_datasync" name="rights.fd_datasync"></a> `fd_datasync`
 The right to invoke `fd_datasync`.
 If `path_open` is set, includes the right to invoke
@@ -487,6 +487,9 @@ Size: 8
 
 Alignment: 8
 
+### Constants
+- <a href="#dircookie.start" name="dircookie.start"></a> `start`
+
 ## <a href="#dirnamlen" name="dirnamlen"></a> `dirnamlen`: `u32`
 The type for the [`dirent::d_namlen`](#dirent.d_namlen) field of [`dirent`](#dirent).
 
@@ -590,14 +593,14 @@ The application expects that it will not access the specified data in the near f
 - <a href="#advice.noreuse" name="advice.noreuse"></a> `noreuse`
 The application expects to access the specified data once and then not reuse it thereafter.
 
-## <a href="#fdflags" name="fdflags"></a> `fdflags`: Flags(`u16`)
+## <a href="#fdflags" name="fdflags"></a> `fdflags`: `u16`
 File descriptor flags.
 
 Size: 2
 
 Alignment: 2
 
-### Flags
+### Constants
 - <a href="#fdflags.append" name="fdflags.append"></a> `append`
 Append mode: Data written to the file is always appended to the file's end.
 
@@ -652,14 +655,14 @@ Size: 8
 
 Alignment: 8
 
-## <a href="#fstflags" name="fstflags"></a> `fstflags`: Flags(`u16`)
+## <a href="#fstflags" name="fstflags"></a> `fstflags`: `u16`
 Which file time attributes to adjust.
 
 Size: 2
 
 Alignment: 2
 
-### Flags
+### Constants
 - <a href="#fstflags.atim" name="fstflags.atim"></a> `atim`
 Adjust the last data access timestamp to the value stored in [`filestat::atim`](#filestat.atim).
 
@@ -672,25 +675,25 @@ Adjust the last data modification timestamp to the value stored in [`filestat::m
 - <a href="#fstflags.mtim_now" name="fstflags.mtim_now"></a> `mtim_now`
 Adjust the last data modification timestamp to the time of clock [`clockid::realtime`](#clockid.realtime).
 
-## <a href="#lookupflags" name="lookupflags"></a> `lookupflags`: Flags(`u32`)
+## <a href="#lookupflags" name="lookupflags"></a> `lookupflags`: `u32`
 Flags determining the method of how paths are resolved.
 
 Size: 4
 
 Alignment: 4
 
-### Flags
+### Constants
 - <a href="#lookupflags.symlink_follow" name="lookupflags.symlink_follow"></a> `symlink_follow`
 As long as the resolved path corresponds to a symbolic link, it is expanded.
 
-## <a href="#oflags" name="oflags"></a> `oflags`: Flags(`u16`)
+## <a href="#oflags" name="oflags"></a> `oflags`: `u16`
 Open flags used by `path_open`.
 
 Size: 2
 
 Alignment: 2
 
-### Flags
+### Constants
 - <a href="#oflags.create" name="oflags.create"></a> `create`
 Create file if it does not exist.
 
@@ -710,7 +713,7 @@ Size: 8
 
 Alignment: 8
 
-## <a href="#permissions" name="permissions"></a> `permissions`: Flags(`u8`)
+## <a href="#permissions" name="permissions"></a> `permissions`: `u8`
 File permissions. This represents the permissions associated with a
 file in a filesystem, and don't fully reflect all the conditions
 which determine whether a given WASI program can access the file.
@@ -719,7 +722,7 @@ Size: 1
 
 Alignment: 1
 
-### Flags
+### Constants
 - <a href="#permissions.read" name="permissions.read"></a> `read`
 For files, permission to read the file.
 For directories, permission to do [`readdir`](#readdir) and access files
@@ -825,15 +828,15 @@ available for reading. This event always triggers for regular files.
 File descriptor [`subscription_fd_readwrite::fd`](#subscription_fd_readwrite.fd) has capacity
 available for writing. This event always triggers for regular files.
 
-## <a href="#eventrwflags" name="eventrwflags"></a> `eventrwflags`: Flags(`u16`)
+## <a href="#eventrwflags" name="eventrwflags"></a> `eventrwflags`: `u16`
 The state of the file descriptor subscribed to with
 [`eventtype::fd_read`](#eventtype.fd_read) or [`eventtype::fd_write`](#eventtype.fd_write).
 
 Size: 2
 
 Alignment: 2
 
-### Flags
+### Constants
 - <a href="#eventrwflags.fd_readwrite_hangup" name="eventrwflags.fd_readwrite_hangup"></a> `fd_readwrite_hangup`
 The peer of this socket has closed or disconnected.
 
@@ -899,15 +902,15 @@ The type of the event that occurred, and the contents of the event
 
 Offset: 16
 
-## <a href="#subclockflags" name="subclockflags"></a> `subclockflags`: Flags(`u16`)
+## <a href="#subclockflags" name="subclockflags"></a> `subclockflags`: `u16`
 Flags determining how to interpret the timestamp provided in
 [`subscription_clock::timeout`](#subscription_clock.timeout).
 
 Size: 2
 
 Alignment: 2
 
-### Flags
+### Constants
 - <a href="#subclockflags.subscription_clock_abstime" name="subclockflags.subscription_clock_abstime"></a> `subscription_clock_abstime`
 If set, treat the timestamp provided in
 [`subscription_clock::timeout`](#subscription_clock.timeout) as an absolute timestamp of clock
@@ -1004,28 +1007,28 @@ Size: 4
 
 Alignment: 4
 
-## <a href="#riflags" name="riflags"></a> `riflags`: Flags(`u16`)
+## <a href="#riflags" name="riflags"></a> `riflags`: `u16`
 Flags provided to `sock_recv`.
 
 Size: 2
 
 Alignment: 2
 
-### Flags
+### Constants
 - <a href="#riflags.recv_peek" name="riflags.recv_peek"></a> `recv_peek`
 Returns the message without removing it from the socket's receive queue.
 
 - <a href="#riflags.recv_waitall" name="riflags.recv_waitall"></a> `recv_waitall`
 On byte-stream sockets, block until the full amount of data can be returned.
 
-## <a href="#roflags" name="roflags"></a> `roflags`: Flags(`u16`)
+## <a href="#roflags" name="roflags"></a> `roflags`: `u16`
 Flags returned by `sock_recv`.
 
 Size: 2
 
 Alignment: 2
 
-### Flags
+### Constants
 - <a href="#roflags.recv_data_truncated" name="roflags.recv_data_truncated"></a> `recv_data_truncated`
 Returned by `sock_recv`: Message data has been truncated.
 
@@ -1037,14 +1040,14 @@ Size: 2
 
 Alignment: 2
 
-## <a href="#sdflags" name="sdflags"></a> `sdflags`: Flags(`u8`)
+## <a href="#sdflags" name="sdflags"></a> `sdflags`: `u8`
 Which channels on a socket to shut down.
 
 Size: 1
 
 Alignment: 1
 
-### Flags
+### Constants
 - <a href="#sdflags.rd" name="sdflags.rd"></a> `rd`
 Disables further receive operations.
 

phases/ephemeral/witx/typenames.witx

@@ -195,7 +195,7 @@
 
 ;;; File descriptor rights, determining which actions may be performed.
 (typename $rights
-  (flags u64
+  (flags (@witx bitflags u64)
     ;;; The right to invoke `fd_datasync`.
     ;;
     ;;; If `path_open` is set, includes the right to invoke
@@ -392,7 +392,7 @@
 
 ;;; File descriptor flags.
 (typename $fdflags
-  (flags u16
+  (flags (@witx bitflags u16)
     ;;; Append mode: Data written to the file is always appended to the file's end.
     $append
     ;;; Write according to synchronized I/O data integrity completion. Only the data stored in the file is synchronized.
@@ -429,7 +429,7 @@
 
 ;;; Which file time attributes to adjust.
 (typename $fstflags
-  (flags u16
+  (flags (@witx bitflags u16)
     ;;; Adjust the last data access timestamp to the value stored in `filestat::atim`.
     $atim
     ;;; Adjust the last data access timestamp to the time of clock `clockid::realtime`.
@@ -443,15 +443,15 @@
 
 ;;; Flags determining the method of how paths are resolved.
 (typename $lookupflags
-  (flags u32
+  (flags (@witx bitflags u32)
     ;;; As long as the resolved path corresponds to a symbolic link, it is expanded.
     $symlink_follow
   )
 )
 
 ;;; Open flags used by `path_open`.
 (typename $oflags
-  (flags u16
+  (flags (@witx bitflags u16)
     ;;; Create file if it does not exist.
     $create
     ;;; Fail if not a directory.
@@ -470,7 +470,7 @@
 ;;; file in a filesystem, and don't fully reflect all the conditions
 ;;; which determine whether a given WASI program can access the file.
 (typename $permissions
-  (flags u8
+  (flags (@witx bitflags u8)
     ;;; For files, permission to read the file.
     ;;; For directories, permission to do `readdir` and access files
     ;;; within the directory.
@@ -543,7 +543,7 @@
 ;;; The state of the file descriptor subscribed to with
 ;;; `eventtype::fd_read` or `eventtype::fd_write`.
 (typename $eventrwflags
-  (flags u16
+  (flags (@witx bitflags u16)
     ;;; The peer of this socket has closed or disconnected.
     $fd_readwrite_hangup
   )
@@ -584,7 +584,7 @@
 ;;; Flags determining how to interpret the timestamp provided in
 ;;; `subscription_clock::timeout`.
 (typename $subclockflags
-  (flags u16
+  (flags (@witx bitflags u16)
     ;;; If set, treat the timestamp provided in
     ;;; `subscription_clock::timeout` as an absolute timestamp of clock
     ;;; `subscription_clock::id`. If clear, treat the timestamp
@@ -643,7 +643,7 @@
 
 ;;; Flags provided to `sock_recv`.
 (typename $riflags
-  (flags u16
+  (flags (@witx bitflags u16)
     ;;; Returns the message without removing it from the socket's receive queue.
     $recv_peek
     ;;; On byte-stream sockets, block until the full amount of data can be returned.
@@ -653,7 +653,7 @@
 
 ;;; Flags returned by `sock_recv`.
 (typename $roflags
-  (flags u16
+  (flags (@witx bitflags u16)
     ;;; Returned by `sock_recv`: Message data has been truncated.
     $recv_data_truncated
   )
@@ -665,7 +665,7 @@
 
 ;;; Which channels on a socket to shut down.
 (typename $sdflags
-  (flags u8
+  (flags (@witx bitflags u8)
     ;;; Disables further receive operations.
     $rd
     ;;; Disables further send operations.