Fix fuzztest compiler warnings [NFC] (#7380)

kripken · web-flow · commit 26390745069e · 2025-03-19T15:17:54.000-07:00
First is an unused variable, second is an unneeded move.
diff --git a/test/gtest/type-domains.cpp b/test/gtest/type-domains.cpp
@@ -725,7 +725,7 @@ fuzztest::Domain<TypePlan> AvailableType(TypeBuilderPlan plan) {
 
 fuzztest::Domain<TypePlan> AvailableSubType(TypeBuilderPlan plan,
                                             TypePlan super) {
-  if (auto* type = super.getNonRef()) {
+  if (super.getNonRef()) {
     // No subtyping among non-ref types.
     return fuzztest::Just(super);
   } else if (auto* ref = super.getRef()) {
@@ -1046,7 +1046,7 @@ std::vector<HeapType> BuildHeapTypes(TypeBuilderPlan plan) {
     ;
   }
   assert(built);
-  return std::move(*built);
+  return *built;
 }
 
 auto ArbitraryDefinedHeapTypesAndPlan() {

Original file line number	Diff line number	Diff line change
`@@ -725,7 +725,7 @@ fuzztest::Domain<TypePlan> AvailableType(TypeBuilderPlan plan) {`
`725`	`725`
`726`	`726`	`fuzztest::Domain<TypePlan> AvailableSubType(TypeBuilderPlan plan,`
`727`	`727`	`TypePlan super) {`
`728`		`- if (auto* type = super.getNonRef()) {`
	`728`	`+ if (super.getNonRef()) {`
`729`	`729`	`// No subtyping among non-ref types.`
`730`	`730`	`return fuzztest::Just(super);`
`731`	`731`	`} else if (auto* ref = super.getRef()) {`
`@@ -1046,7 +1046,7 @@ std::vector<HeapType> BuildHeapTypes(TypeBuilderPlan plan) {`
`1046`	`1046`	`;`
`1047`	`1047`	`}`
`1048`	`1048`	`assert(built);`
`1049`		`- return std::move(*built);`
	`1049`	`+ return *built;`
`1050`	`1050`	`}`
`1051`	`1051`
`1052`	`1052`	`auto ArbitraryDefinedHeapTypesAndPlan() {`