Skip to content

Commit 33e337e

Browse files
authored
Add virtual destructor to fix build warning/error (#1793)
This error started showing up after: #1779 error: delete called on non-final 'wasm::ShellExternalInterface' that has virtual functions but non-virtual destructor
1 parent 3814fd6 commit 33e337e

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

src/shell-interface.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,7 @@ struct ShellExternalInterface : ModuleInstance::ExternalInterface {
9191
std::vector<Name> table;
9292

9393
ShellExternalInterface() : memory() {}
94+
virtual ~ShellExternalInterface() = default;
9495

9596
void init(Module& wasm, ModuleInstance& instance) override {
9697
memory.resize(wasm.memory.initial * wasm::Memory::kPageSize);

0 commit comments

Comments
 (0)