fin

Author: kripken

src/passes/OptimizeInstructions.cpp

@@ -1801,8 +1801,8 @@ struct OptimizeInstructions
 
   void visitRefEq(RefEq* curr) {
     // Check for unreachability. Note we must check both the children and the
-    // ref.eq itself, as in e.g. visitTernary, as we only refinalize at the end,
-    // so unreachable children may not update the parent yet.
+    // ref.eq itself, as in e.g. optimizeTernary, as we only refinalize at the
+    // end, so unreachable children may not update the parent yet.
     auto leftType = curr->left->type;
     auto rightType = curr->right->type;
     if (leftType == Type::unreachable || rightType == Type::unreachable ||

test/lit/passes/optimize-instructions-gc.wast

@@ -3719,7 +3719,8 @@
     ;; arm is i31, the other a struct, both non-nullable, and hence there is no
     ;; overlap). If we do that, and emit a 0, we'd be turning an unreachable
     ;; into a concrete type, and nothing pops that type off the stack, so we
-    ;; would fail to validate.
+    ;; would fail to validate. Instead, we should leave this code for DCE, aside
+    ;; from moving the ref.i31 out.
     (ref.eq
       (if (result (ref i31))
         (unreachable)