Skip to content

Commit b650f20

Browse files
authored
Warn if linking section is present, as we cannot handle it yet (#1798)
1 parent bebbeb5 commit b650f20

File tree

3 files changed

+5
-2
lines changed

3 files changed

+5
-2
lines changed

src/wasm-binary.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -341,8 +341,8 @@ enum EncodedType {
341341
namespace UserSections {
342342
extern const char* Name;
343343
extern const char* SourceMapUrl;
344-
345344
extern const char* Dylink;
345+
extern const char* Linking;
346346

347347
enum Subsection {
348348
NameFunction = 1,

src/wasm/wasm-binary.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -713,6 +713,9 @@ void WasmBinaryBuilder::readUserSection(size_t payloadLen) {
713713
readNames(payloadLen - (pos - oldPos));
714714
} else {
715715
// an unfamiliar custom section
716+
if (sectionName.equals(BinaryConsts::UserSections::Linking)) {
717+
std::cerr << "warning: linking section is present, which binaryen cannot handle yet - relocations will be invalidated!\n";
718+
}
716719
wasm.userSections.resize(wasm.userSections.size() + 1);
717720
auto& section = wasm.userSections.back();
718721
section.name = sectionName.str;

src/wasm/wasm.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,8 @@ namespace BinaryConsts {
2929
namespace UserSections {
3030
const char* Name = "name";
3131
const char* SourceMapUrl = "sourceMappingURL";
32-
3332
const char* Dylink = "dylink";
33+
const char* Linking = "linking";
3434
}
3535
}
3636

0 commit comments

Comments
 (0)