Skip to content

Commit c24f90c

Browse files
committed
address comments
1 parent 05ce530 commit c24f90c

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

src/binaryen-c.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,6 @@ struct BinaryenLiteral {
229229
double f64;
230230
uint8_t v128[16];
231231
const char* func;
232-
// std::unique_ptr exn;
233232
};
234233
};
235234

src/literal.h

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -33,19 +33,18 @@ class Literals;
3333
struct ExceptionPackage;
3434

3535
class Literal {
36-
37-
private:
3836
// store only integers, whose bits are deterministic. floats
3937
// can have their signalling bit set, for example.
4038
union {
4139
int32_t i32;
4240
int64_t i64;
4341
uint8_t v128[16];
44-
// funcref function name. not set indicates `null`.
42+
// funcref function name. `isNull()` indicates a `null` value.
4543
Name func;
46-
// exnref package. not set indicates `null`.
44+
// exnref package. `nullptr` indicates a `null` value.
4745
std::unique_ptr<ExceptionPackage> exn;
48-
// literals of other reference types can only be `null`
46+
// TODO: Literals of type `externref`, `anyref` and `eqref can only be
47+
// `null` currently. Literals of type `i31ref` are not yet supported.
4948
};
5049

5150
public:

0 commit comments

Comments
 (0)