Fuzzer: Run Two() using the Binaryen interpreter #7954
+72
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This must wait to land on fixing the issues this finds. So far I see one with imported tags. |
tlively
reviewed
Oct 7, 2025
scripts/fuzz_opt.py
Outdated
| if output == IGNORE: | ||
| return | ||
|
|
||
| if output.startswith(INSTANTIATE_ERROR): |
There was a problem hiding this comment.
We can probably skip the check below and immediately report a problem, since our interpreter did not trap in instantiation. It also might be worth checking the other direction by running V8 when the interpreter traps in instantiation to make sure V8 also traps in instantiation.
There was a problem hiding this comment.
There are host errors though which differ between VMs, like limits on array.new size etc.
There was a problem hiding this comment.
Oh, but we do handle IGNORE earlier, so you are right: only deterministic things should remain at this point. I simplified it now.
tlively
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using our interpreter in addition to V8 allows our assertions to also
be checked, potentially finding more issues.
Also, we can run our interpreter on more code (e.g. V8 comparisons
are unreliable if there are NANs, due to V8's nondeterminism
differing from ours).
To make this work, fix execution-results to match fuzz_shell.js's
behavior: First instantiate both modules when running two of
them, and then run their exports (this makes it easy to see if
we error during instantiation).