Skip to content

Commit ac37fe9

Browse files
authored
update tests to match new reentrance rules (#596)
Recent discussions [^1] regarding optimizing reentrance checks in fused adapters have resulted in a plan to disallow lowering a lift where the lowering instance is an ancestor of the lifting instance or vice-versa. A bunch of tests in `fused.wast` were doing that, so I've updated them to not do that. In addition, I'm about to open a Wasmtime PR to enforce the new rule and subsume existing code that created "degenerate adapter" functions for self-to-self lift/lower pairs. Consequently, I've updated `adapter.wast` to expect a "cannot enter component instance" trap instead of a "degenerate component adapter" one. [^1]: https://bytecodealliance.zulipchat.com/#narrow/channel/217126-wasmtime/topic/Wasmtime.20sync.3C-.3Esync.20adapter.20optimizability
1 parent 0b951b7 commit ac37fe9

File tree

2 files changed

+198
-166
lines changed

2 files changed

+198
-166
lines changed

test/wasmtime/adapter.wast

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@
112112
(with "" (instance (export "" (func $f2))))
113113
))
114114
)
115-
"degenerate component adapter called")
115+
"cannot enter component instance")
116116

117117
;; fiddling with 0-sized lists
118118
(component $c

0 commit comments

Comments
 (0)