Merge pull request #214 from alexcrichton/fix-lift-own

lukewagner · web-flow · commit d445b5aba9a4 · 2023-07-11T10:22:59.000-05:00
Fix lifting an own handle from a borrow handle
diff --git a/design/mvp/CanonicalABI.md b/design/mvp/CanonicalABI.md
@@ -641,6 +641,7 @@ component.
 ```python
 def lift_own(cx, i, t):
   h = cx.inst.handles.remove(t.rt, i)
+  trap_if(not h.own)
   return h.rep
 ```
 The abstract lifted value for handle types is currently just the internal
diff --git a/design/mvp/canonical-abi/definitions.py b/design/mvp/canonical-abi/definitions.py
@@ -544,6 +544,7 @@ def unpack_flags_from_int(i, labels):
 
 def lift_own(cx, i, t):
   h = cx.inst.handles.remove(t.rt, i)
+  trap_if(not h.own)
   return h.rep
 
 def lift_borrow(cx, i, t):
