Make Echidna status checking tolerate transient failure #1856
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It often happens that checking the Echinda status too quickly after request upload results in failure (to get the validation results), but checking it shortly after that would result in success. So, make the status-check script retry a couple of times on failure.
|
Weird that the retries are failing with different errors, but clicking the link in a real browser works just fine. |
tlively
reviewed
Dec 18, 2024
| raise Exception('Failed to fetch echidna result') | ||
| retry -= 1 | ||
| if retry: | ||
| print('Retrying in 5s') |
There was a problem hiding this comment.
I don't see where the actual sleep is happening. Maybe sleeping for real will help?
|
Oh dear, maybe I've killed Echidna again... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It often happens that checking the Echinda status too quickly after request upload results in failure (to get the validation results), but checking it shortly after that would result in success. So, make the status-check script retry a couple of times on failure.