Fix bug in wasm2c's tail-call optimization code generation (#2420)

squk · web-flow · commit d1e54a842c8f · 2024-05-14T16:05:02.000Z
diff --git a/src/c-writer.cc b/src/c-writer.cc
@@ -1858,7 +1858,7 @@ void CWriter::WriteTailCallWeakImports() {
     Index num_results = func.GetNumResults();
     if (num_params >= 1) {
       Write(func.decl.sig.param_types, " params;", Newline());
-      Write("wasm_rt_memcpy(params, tail_call_stack, sizeof(params);",
+      Write("wasm_rt_memcpy(params, tail_call_stack, sizeof(params));",
             Newline());
     }
 
diff --git a/test/wasm2c/tail-calls.txt b/test/wasm2c/tail-calls.txt
@@ -766,7 +766,7 @@ WEAK_FUNC_DECL(wasm_tailcall_w2c_spectest_print_i32_f32, wasm_fallback_test_w2c_
 {
   next->fn = NULL;
   struct wasm_multi_if params;
-  wasm_rt_memcpy(params, tail_call_stack, sizeof(params);
+  wasm_rt_memcpy(params, tail_call_stack, sizeof(params));
   w2c_spectest_print_i32_f32(*instance_ptr, params.i0, params.f1);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -1858,7 +1858,7 @@ void CWriter::WriteTailCallWeakImports() {`
`1858`	`1858`	`Index num_results = func.GetNumResults();`
`1859`	`1859`	`if (num_params >= 1) {`
`1860`	`1860`	`Write(func.decl.sig.param_types, " params;", Newline());`
`1861`		`- Write("wasm_rt_memcpy(params, tail_call_stack, sizeof(params);",`
	`1861`	`+ Write("wasm_rt_memcpy(params, tail_call_stack, sizeof(params));",`
`1862`	`1862`	`Newline());`
`1863`	`1863`	`}`
`1864`	`1864`
Original file line number	Diff line number	Diff line change
`@@ -766,7 +766,7 @@ WEAK_FUNC_DECL(wasm_tailcall_w2c_spectest_print_i32_f32, wasm_fallback_test_w2c_`
`766`	`766`	`{`
`767`	`767`	`next->fn = NULL;`
`768`	`768`	`struct wasm_multi_if params;`
`769`		`- wasm_rt_memcpy(params, tail_call_stack, sizeof(params);`
	`769`	`+ wasm_rt_memcpy(params, tail_call_stack, sizeof(params));`
`770`	`770`	`w2c_spectest_print_i32_f32(*instance_ptr, params.i0, params.f1);`
`771`	`771`	`}`
`772`	`772`