more showHints and showSource changes

Author: lawson89

src/main/java/org/owasp/webgoat/lessons/model/LessonMenuItem.java

@@ -44,8 +44,8 @@ public class LessonMenuItem {
     private List<LessonMenuItem> children = new ArrayList<LessonMenuItem>();
     private boolean complete;
     private String link;
-    private boolean showSource;
-    private boolean showHints;
+    private boolean showSource = true;
+    private boolean showHints = true;
 
     /**
      * @return the name

src/main/java/org/owasp/webgoat/service/LessonMenuService.java

@@ -86,16 +86,16 @@ List<LessonMenuItem> showLeftNav(HttpSession session) {
                 if (lesson.isCompleted(ws)) {
                     lessonItem.setComplete(true);
                 }
+                /* @TODO - do this in a more efficient way 
+                 if (lesson.isAuthorized(ws, role, WebSession.SHOWHINTS)) {
+                 lessonItem.setShowHints(true);
+                 }
 
-                if (lesson.isAuthorized(ws, role, WebSession.SHOWHINTS)) {
-                    lessonItem.setShowHints(true);
-                }
-
-                if (lesson.isAuthorized(ws, role, WebSession.SHOWSOURCE)) {
-                    lessonItem.setShowSource(true);
-                }
-
-                // special handling for challenge role 
+                 if (lesson.isAuthorized(ws, role, WebSession.SHOWSOURCE)) {
+                 lessonItem.setShowSource(true);
+                 }
+                 */
+                // special handling for challenge role
                 if (Category.CHALLENGE.equals(lesson.getCategory())) {
                     lessonItem.setShowHints(lesson.isAuthorized(ws, AbstractLesson.CHALLENGE_ROLE, WebSession.SHOWHINTS));
                     lessonItem.setShowSource(lesson.isAuthorized(ws, AbstractLesson.CHALLENGE_ROLE, WebSession.SHOWHINTS));