Skip to content

Commit e0da681

Browse files
committed
Resolve HttpOnly Test bug WEB-161
1 parent e77dda3 commit e0da681

File tree

1 file changed

+10
-4
lines changed

1 file changed

+10
-4
lines changed

src/main/java/org/owasp/webgoat/lessons/HttpOnly.java

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,8 @@ public class HttpOnly extends LessonAdapter
6161

6262
private final static String HTTPONLY = "httponly";
6363

64+
private final static String HTTPONLY_VALUE = "httponly_value";
65+
6466
private final static String ACTION = "action";
6567

6668
private final static String READ = "Read Cookie";
@@ -239,6 +241,7 @@ private ElementContainer makeContent(WebSession s)
239241
{
240242
ElementContainer ec = new ElementContainer();
241243
Element r = null;
244+
Element hidden_r = null;
242245
Table t = null;
243246
TR tr = null;
244247
Form f = null;
@@ -266,11 +269,12 @@ private ElementContainer makeContent(WebSession s)
266269

267270
if (httpOnly == true)
268271
{
269-
r = new Input(Input.RADIO, HTTPONLY, "True").addAttribute("Checked", "true");
272+
r = new Input(Input.RADIO, HTTPONLY_VALUE, "True").addAttribute("Checked", "true");
270273
}
271274
else
272275
{
273-
r = new Input(Input.RADIO, HTTPONLY, "True").addAttribute("onClick", "document.form.submit()");
276+
r = new Input(Input.RADIO, HTTPONLY_VALUE, "True").addAttribute("onClick", "document.form.httponly.click();");
277+
hidden_r = new Input(Input.SUBMIT, HTTPONLY, "True").addAttribute("style", "visibility:hidden");
274278
}
275279

276280
tr.addElement(new TD(r));
@@ -279,14 +283,16 @@ private ElementContainer makeContent(WebSession s)
279283

280284
if (httpOnly == false)
281285
{
282-
r = new Input(Input.RADIO, HTTPONLY, "False").addAttribute("Checked", "True");
286+
r = new Input(Input.RADIO, HTTPONLY_VALUE, "False").addAttribute("Checked", "false");
283287
}
284288
else
285289
{
286-
r = new Input(Input.RADIO, HTTPONLY, "False").addAttribute("onClick", "document.form.submit()");
290+
r = new Input(Input.RADIO, HTTPONLY_VALUE, "False").addAttribute("onClick", "document.form.httponly.click();");
291+
hidden_r = new Input(Input.SUBMIT, HTTPONLY, "False").addAttribute("style", "visibility:hidden");
287292
}
288293

289294
tr.addElement(new TD(r));
295+
tr.addElement(hidden_r);
290296

291297
r = new Input(Input.HIDDEN, READ_RESULT, "");
292298
tr.addElement(r);

0 commit comments

Comments
 (0)