Skip to content

Commit 865bbc4

Browse files
committed
Add documentation on updating Cmake Headers
#18 This is a port of Vitor's change here WebKit/WebKit#7553. We are adding instructions on how to add files to Cmake.
1 parent 424f546 commit 865bbc4

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

docs/Deep Dive/Build/AddingNewFile.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,8 @@ To do that, turn on the target membership in respective framework as set the mem
1818
This will ensure the relevant header file is exported from WTF / WebCore to other downstream projects like WebKitLegacy.
1919
![Screenshot of exporting a header file](../../assets/xcode-export-header.png)
2020

21-
FIXME: Mention WTF_EXPORT_PRIVATE and WEBCORE_EXPORT.
22-
23-
FIXME: Add instructions on how to add files to CMake.
21+
Non-cocoa ports, like WPE and GTK, use CMake for building the project. If the header is not platform-specific, you might
22+
want to add an entry for it into the relevant Headers.cmake. For example, if a WebCore header is included by WebKit, you
23+
will need to list the header in Source/WebCore/Headers.cmake.
2424

25+
FIXME: Mention WTF_EXPORT_PRIVATE and WEBCORE_EXPORT.

0 commit comments

Comments
 (0)