Skip to content

Commit 7a4d24d

Browse files
committed
Address review comments
1 parent dc2cb39 commit 7a4d24d

File tree

2 files changed

+7
-8
lines changed

2 files changed

+7
-8
lines changed

Dart/build.sh

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,7 @@ echo "Copying files from wasm_gc_benchmarks/ into build/" | tee -a "$BUILD_LOG"
1818
mkdir -p build/ | tee -a "$BUILD_LOG"
1919
# Generic Dart2wasm runner.
2020
cp wasm_gc_benchmarks/tools/run_wasm.js build/ | tee -a "$BUILD_LOG"
21-
# "Flute Complex" benchmark application.
22-
# cp wasm_gc_benchmarks/benchmarks-out/flute.complex.dart2wasm.mjs build/flute.dart2wasm.mjs | tee -a "$BUILD_LOG"
23-
# cp wasm_gc_benchmarks/benchmarks-out/flute.complex.dart2wasm.wasm build/flute.dart2wasm.wasm | tee -a "$BUILD_LOG"
21+
# Two Flute benchmark applications: complex and todomvc
2422
cp wasm_gc_benchmarks/benchmarks-out/flute.complex.dart2wasm.{mjs,wasm} build/ | tee -a "$BUILD_LOG"
2523
cp wasm_gc_benchmarks/benchmarks-out/flute.todomvc.dart2wasm.{mjs,wasm} build/ | tee -a "$BUILD_LOG"
2624

JetStreamDriver.js

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -740,7 +740,7 @@ class Benchmark {
740740
__benchmark.runIteration();
741741
let end = performance.now();
742742
743-
// performance.measure(iterationMarkLabel, iterationMarkLabel);
743+
performance.measure(iterationMarkLabel, iterationMarkLabel);
744744
745745
${this.postIterationCode}
746746
@@ -1233,7 +1233,7 @@ class AsyncBenchmark extends DefaultBenchmark {
12331233
await __benchmark.runIteration();
12341234
let end = performance.now();
12351235
1236-
// performance.measure(iterationMarkLabel, iterationMarkLabel);
1236+
performance.measure(iterationMarkLabel, iterationMarkLabel);
12371237
12381238
${this.postIterationCode}
12391239
@@ -1314,7 +1314,7 @@ class WSLBenchmark extends Benchmark {
13141314
benchmark.buildStdlib();
13151315
results.push(performance.now() - start);
13161316
1317-
// performance.measure(markLabel, markLabel);
1317+
performance.measure(markLabel, markLabel);
13181318
}
13191319
13201320
{
@@ -1325,7 +1325,7 @@ class WSLBenchmark extends Benchmark {
13251325
benchmark.run();
13261326
results.push(performance.now() - start);
13271327
1328-
// performance.measure(markLabel, markLabel);
1328+
performance.measure(markLabel, markLabel);
13291329
}
13301330
13311331
top.currentResolve(results);
@@ -2068,6 +2068,7 @@ let BENCHMARKS = [
20682068
iterations: 15,
20692069
worstCaseCount: 2,
20702070
tags: ["Wasm"],
2071+
disabledByDefault: true,
20712072
}),
20722073
new WasmEMCCBenchmark({
20732074
name: "Dart-flute-todomvc-wasm",
@@ -2078,7 +2079,7 @@ let BENCHMARKS = [
20782079
jsModule: "./Dart/build/flute.todomvc.dart2wasm.mjs",
20792080
wasmBinary: "./Dart/build/flute.todomvc.dart2wasm.wasm",
20802081
},
2081-
iterations: 15,
2082+
iterations: 30,
20822083
worstCaseCount: 2,
20832084
tags: ["Default", "Wasm"],
20842085
}),

0 commit comments

Comments
 (0)