Address review comments

Author: eqrion

.github/workflows/test.yml

@@ -40,7 +40,7 @@ jobs:
               run: npm ci
 
             - name: Decompress compressed files
-              run: node utils/compress.mjs -d -k
+              run: npm run decompress
 
             - name: Cache jsvu Binaries 
               uses: actions/cache@v4

JetStreamDriver.js

@@ -31,7 +31,7 @@ const defaultIterationCount = 120;
 const defaultWorstCaseCount = 4;
 
 if (!JetStreamParams.prefetchResources)
-    console.warn("Disabling resource prefetching! All compressed files must have been decompressed using `node utils/compress.mjs -d -k`");
+    console.warn("Disabling resource prefetching! All compressed files must have been decompressed using `npm run decompress`");
 
 if (!isInBrowser && JetStreamParams.prefetchResources) {
     // Use the wasm compiled zlib as a polyfill when decompression stream is
@@ -190,7 +190,7 @@ class ShellFileLoader {
 
         let contents;
         if (compressed) {
-            let bytes = new Int8Array(read(url, "binary"));
+            const bytes = new Int8Array(read(url, "binary"));
             bytes = zlib.decompress(bytes);
             contents = new TextDecoder().decode(bytes);
         } else {
@@ -947,7 +947,7 @@ class Benchmark {
         // If we need to decompress this, then run it through a decompression
         // stream.
         if (compressed) {
-            const stream = response.body.pipeThrough(new DecompressionStream('deflate'))
+            const stream = response.body.pipeThrough(new DecompressionStream("deflate"))
             response = new Response(stream);
         }
 
@@ -1089,23 +1089,24 @@ class Benchmark {
         console.assert(this.preloads === null, "This initialization should be called only once.");
         this.preloads = [];
         this.shellPrefetchedResources = Object.create(null);
-        if (this.plan.preload) {
-            for (let [name, file] of Object.entries(this.plan.preload)) {
-                const compressed = isCompressed(file);
-                if (compressed && !JetStreamParams.prefetchResources) {
-                    file = uncompressedName(file);
-                }
+        if (!this.plan.preload) {
+            return;
+        }
+        for (let [name, file] of Object.entries(this.plan.preload)) {
+            const compressed = isCompressed(file);
+            if (compressed && !JetStreamParams.prefetchResources) {
+                file = uncompressedName(file);
+            }
 
-                if (JetStreamParams.prefetchResources) {
-                    let bytes = new Int8Array(read(file, "binary"));
-                    if (compressed) {
-                        bytes = zlib.decompress(bytes);
-                    }
-                    this.shellPrefetchedResources[file] = bytes;
+            if (JetStreamParams.prefetchResources) {
+                let bytes = new Int8Array(read(file, "binary"));
+                if (compressed) {
+                    bytes = zlib.decompress(bytes);
                 }
-
-                this.preloads.push([name, file]);
+                this.shellPrefetchedResources[file] = bytes;
             }
+
+            this.preloads.push([name, file]);
         }
     }
 

package.json

@@ -17,6 +17,7 @@
     "scripts": {
         "server": "node tests/server.mjs",
         "compress": "node utils/compress.mjs",
+        "decompress": "node utils/compress.mjs -d -k",
         "lint:check": "eslint **/*.{js,mjs,jsx,ts,tsx}",
         "pretty:check": "prettier --check ./",
         "format:check": "npm run pretty:check && npm run lint:check",

wasm/zlib/shell.js

@@ -2,7 +2,7 @@
 // DecompressionStream are not available.
 
 function module() {
-  'use strict';
+  "use strict";
 
   let zlibPromise = null;
   let zlibModule = null;

web-tooling-benchmark/benchmark.js

@@ -39,7 +39,7 @@ class Benchmark {
     const loadPromises = Object.entries(preload).map(
       async ([name, url]) => {
         if (name.endsWith(".wasm")) {
-          let buffer = (await JetStream.getBinary(url)).buffer;
+          const buffer = (await JetStream.getBinary(url)).buffer;
           if (!(buffer instanceof ArrayBuffer)) {
             // The returned array buffer is from a different global when
             // prefetching resources and running in the shell. This is fine,