Skip to content

Commit c5dac10

Browse files
committed
Change shouldReport to report back
Some of critical toolings are relying on this name, and this naming change broke the possible mechanism to run the tests in an uniform way between JetStream2 / JetStream3. This patch changes shouldReport back to report to urgently fix this issue for now.
1 parent a26d33b commit c5dac10

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

JetStreamDriver.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -455,7 +455,7 @@ class Driver {
455455
if (!isInBrowser)
456456
return;
457457

458-
if (!JetStreamParams.shouldReport)
458+
if (!JetStreamParams.report)
459459
return;
460460

461461
const content = this.resultsJSON();

cli.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ const CLI_PARAMS = {
6868
help: "Start the benchmark automatically.",
6969
param: "startAutomatically",
7070
},
71-
report: { help: "Report results to a server.", param: "shouldReport" },
71+
report: { help: "Report results to a server.", param: "report" },
7272
"start-delay": {
7373
help: "Delay before starting the benchmark.",
7474
param: "startDelay",

params.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ class Params {
3131
// Enable a detailed developer menu to change the current Params.
3232
developerMode = false;
3333
startAutomatically = false;
34-
shouldReport = false;
34+
report = false;
3535
startDelay = undefined;
3636

3737
testList = [];
@@ -64,7 +64,7 @@ class Params {
6464
_copyFromSearchParams(sourceParams) {
6565
this.startAutomatically = this._parseBooleanParam(sourceParams, "startAutomatically");
6666
this.developerMode = this._parseBooleanParam(sourceParams, "developerMode");
67-
this.shouldReport = this._parseBooleanParam(sourceParams, "shouldReport");
67+
this.report = this._parseBooleanParam(sourceParams, "report");
6868
this.prefetchResources = this._parseBooleanParam(sourceParams, "prefetchResources");
6969
this.RAMification = this._parseBooleanParam(sourceParams, "RAMification");
7070
this.dumpJSONResults = this._parseBooleanParam(sourceParams, "dumpJSONResults");
@@ -75,7 +75,7 @@ class Params {
7575
this.customPostIterationCode = this._parseStringParam(sourceParams, "customPostIterationCode");
7676

7777
this.startDelay = this._parseIntParam(sourceParams, "startDelay", 0);
78-
if (this.shouldReport && !this.startDelay)
78+
if (this.report && !this.startDelay)
7979
this.startDelay = 4000;
8080

8181
for (const paramKey of ["tag", "tags", "test", "tests"])

0 commit comments

Comments
 (0)