Skip to content

Commit e1d0884

Browse files
committed
Address review comments
1 parent 824afe6 commit e1d0884

File tree

3 files changed

+19
-20
lines changed

3 files changed

+19
-20
lines changed

Dart/build.sh

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,7 @@ echo "Copying files from wasm_gc_benchmarks/ into build/" | tee -a "$BUILD_LOG"
1818
mkdir -p build/ | tee -a "$BUILD_LOG"
1919
# Generic Dart2wasm runner.
2020
cp wasm_gc_benchmarks/tools/run_wasm.js build/ | tee -a "$BUILD_LOG"
21-
# "Flute Complex" benchmark application.
22-
# cp wasm_gc_benchmarks/benchmarks-out/flute.complex.dart2wasm.mjs build/flute.dart2wasm.mjs | tee -a "$BUILD_LOG"
23-
# cp wasm_gc_benchmarks/benchmarks-out/flute.complex.dart2wasm.wasm build/flute.dart2wasm.wasm | tee -a "$BUILD_LOG"
21+
# Two Flute benchmark applications: complex and todomvc
2422
cp wasm_gc_benchmarks/benchmarks-out/flute.complex.dart2wasm.{mjs,wasm} build/ | tee -a "$BUILD_LOG"
2523
cp wasm_gc_benchmarks/benchmarks-out/flute.todomvc.dart2wasm.{mjs,wasm} build/ | tee -a "$BUILD_LOG"
2624

JetStreamDriver.js

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -650,7 +650,7 @@ class Benchmark {
650650
__benchmark.runIteration();
651651
let end = performance.now();
652652
653-
// performance.measure(iterationMarkLabel, iterationMarkLabel);
653+
performance.measure(iterationMarkLabel, iterationMarkLabel);
654654
655655
${this.postIterationCode}
656656
@@ -1173,7 +1173,7 @@ class AsyncBenchmark extends DefaultBenchmark {
11731173
await __benchmark.runIteration();
11741174
let end = performance.now();
11751175
1176-
// performance.measure(iterationMarkLabel, iterationMarkLabel);
1176+
performance.measure(iterationMarkLabel, iterationMarkLabel);
11771177
11781178
${this.postIterationCode}
11791179
@@ -1272,7 +1272,7 @@ class WSLBenchmark extends Benchmark {
12721272
benchmark.buildStdlib();
12731273
results.push(performance.now() - start);
12741274
1275-
// performance.measure(markLabel, markLabel);
1275+
performance.measure(markLabel, markLabel);
12761276
}
12771277
12781278
{
@@ -1283,7 +1283,7 @@ class WSLBenchmark extends Benchmark {
12831283
benchmark.run();
12841284
results.push(performance.now() - start);
12851285
1286-
// performance.measure(markLabel, markLabel);
1286+
performance.measure(markLabel, markLabel);
12871287
}
12881288
12891289
top.currentResolve(results);
@@ -2073,6 +2073,7 @@ let BENCHMARKS = [
20732073
iterations: 15,
20742074
worstCaseCount: 2,
20752075
tags: ["Wasm"],
2076+
disabledByDefault: true,
20762077
}),
20772078
new WasmEMCCBenchmark({
20782079
name: "Dart-flute-todomvc-wasm",
@@ -2083,7 +2084,7 @@ let BENCHMARKS = [
20832084
jsModule: "./Dart/build/flute.todomvc.dart2wasm.mjs",
20842085
wasmBinary: "./Dart/build/flute.todomvc.dart2wasm.wasm",
20852086
},
2086-
iterations: 15,
2087+
iterations: 30,
20872088
worstCaseCount: 2,
20882089
tags: ["Wasm"],
20892090
}),

wasm-cli.js

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -24,19 +24,19 @@
2424
*/
2525

2626
testList = [
27-
"HashSet-wasm",
28-
"tsf-wasm",
29-
"quicksort-wasm",
30-
"gcc-loops-wasm",
31-
"richards-wasm",
32-
"sqlite3-wasm",
33-
"tfjs-wasm",
34-
"tfjs-wasm-simd",
35-
"argon2-wasm",
36-
"8bitbench-wasm",
37-
"Dart-flute-complex-wasm",
27+
// "HashSet-wasm",
28+
// "tsf-wasm",
29+
// "quicksort-wasm",
30+
// "gcc-loops-wasm",
31+
// "richards-wasm",
32+
// "sqlite3-wasm",
33+
// "tfjs-wasm",
34+
// "tfjs-wasm-simd",
35+
// "argon2-wasm",
36+
// "8bitbench-wasm",
37+
// "Dart-flute-complex-wasm",
3838
"Dart-flute-todomvc-wasm",
39-
"zlib-wasm",
39+
// "zlib-wasm",
4040
];
4141

4242
// Reuse the full CLI runner, just with the subset of Wasm line items above.

0 commit comments

Comments
 (0)