Skip to content

Commit 4239aea

Browse files
committed
[MotionMark] Live version of 4 tests just show a 403 Access Denied page
https://bugs.webkit.org/show_bug.cgi?id=254782 rdar://107208247 Reviewed by Alexey Proskuryakov. Apparently, the firewall that the live MotionMark site is behind doesn't like it when paths that include the "../" string are part of query parameters in URLs. Luckily, MotionMark is already set up to do the right thing when the query parameter is omitted, so this patch just deletes those query parameters and uses the test-specific logic to fall back to the correct string anyway. * Websites/browserbench.org/MotionMark1.2/resources/debug-runner/tests.js: * Websites/browserbench.org/MotionMark1.2/tests/bouncing-particles/resources/bouncing-canvas-images.js: (BouncingCanvasParticlesStage.call.initialize): * Websites/browserbench.org/MotionMark1.2/tests/bouncing-particles/resources/bouncing-svg-images.js: (BouncingSvgParticlesStage.call.initialize): Canonical link: https://commits.webkit.org/262382@main
1 parent 4710d74 commit 4239aea

File tree

3 files changed

+11
-11
lines changed

3 files changed

+11
-11
lines changed

MotionMark1.2/resources/debug-runner/tests.js

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright (C) 2015-2018 Apple Inc. All rights reserved.
2+
* Copyright (C) 2015-2023 Apple Inc. All rights reserved.
33
*
44
* Redistribution and use in source and binary forms, with or without
55
* modification, are permitted provided that the following conditions
@@ -183,7 +183,7 @@ Suites.push(new Suite("HTML suite",
183183
name: "CSS bouncing filter circles"
184184
},
185185
{
186-
url: "bouncing-particles/bouncing-css-images.html?particleWidth=80&particleHeight=80&imageSrc=../resources/yin-yang.svg",
186+
url: "bouncing-particles/bouncing-css-images.html?particleWidth=80&particleHeight=80",
187187
name: "CSS bouncing SVG images"
188188
},
189189
{
@@ -199,7 +199,7 @@ Suites.push(new Suite("HTML suite",
199199
name: "DOM particles, SVG masks"
200200
},
201201
{
202-
url: "dom/compositing-transforms.html?particleWidth=50&particleHeight=50&filters=yes&imageSrc=../resources/yin-yang.svg",
202+
url: "dom/compositing-transforms.html?particleWidth=50&particleHeight=50&filters=yes",
203203
name: "Composited Transforms"
204204
}
205205
]
@@ -216,11 +216,11 @@ Suites.push(new Suite("Canvas suite",
216216
name: "canvas bouncing gradient circles"
217217
},
218218
{
219-
url: "bouncing-particles/bouncing-canvas-images.html?particleWidth=80&particleHeight=80&imageSrc=../resources/yin-yang.svg",
219+
url: "bouncing-particles/bouncing-canvas-images.html?particleWidth=80&particleHeight=80",
220220
name: "canvas bouncing SVG images"
221221
},
222222
{
223-
url: "bouncing-particles/bouncing-canvas-images.html?particleWidth=80&particleHeight=80&imageSrc=../resources/yin-yang.png",
223+
url: "bouncing-particles/bouncing-canvas-images.html?particleWidth=80&particleHeight=80",
224224
name: "canvas bouncing PNG images"
225225
},
226226
{
@@ -253,11 +253,11 @@ Suites.push(new Suite("SVG suite",
253253
name: "SVG bouncing gradient circles"
254254
},
255255
{
256-
url: "bouncing-particles/bouncing-svg-images.html?particleWidth=80&particleHeight=80&imageSrc=../resources/yin-yang.svg",
256+
url: "bouncing-particles/bouncing-svg-images.html?particleWidth=80&particleHeight=80",
257257
name: "SVG bouncing SVG images"
258258
},
259259
{
260-
url: "bouncing-particles/bouncing-svg-images.html?particleWidth=80&particleHeight=80&imageSrc=../resources/yin-yang.png",
260+
url: "bouncing-particles/bouncing-svg-images.html?particleWidth=80&particleHeight=80",
261261
name: "SVG bouncing PNG images"
262262
},
263263
]

MotionMark1.2/tests/bouncing-particles/resources/bouncing-canvas-images.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright (C) 2015-2017 Apple Inc. All rights reserved.
2+
* Copyright (C) 2015-2023 Apple Inc. All rights reserved.
33
*
44
* Redistribution and use in source and binary forms, with or without
55
* modification, are permitted provided that the following conditions
@@ -49,7 +49,7 @@ BouncingCanvasImagesStage = Utilities.createSubclass(BouncingCanvasParticlesStag
4949
initialize: function(benchmark, options)
5050
{
5151
BouncingCanvasParticlesStage.prototype.initialize.call(this, benchmark, options);
52-
var imageSrc = options["imageSrc"] || "resources/yin-yang.svg";
52+
var imageSrc = options["imageSrc"] || "../resources/yin-yang.svg";
5353
this.imageElement = document.querySelector(".hidden[src=\"" + imageSrc + "\"]");
5454
},
5555

MotionMark1.2/tests/bouncing-particles/resources/bouncing-svg-images.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*
2-
* Copyright (C) 2015-2017 Apple Inc. All rights reserved.
2+
* Copyright (C) 2015-2023 Apple Inc. All rights reserved.
33
*
44
* Redistribution and use in source and binary forms, with or without
55
* modification, are permitted provided that the following conditions
@@ -45,7 +45,7 @@ BouncingSvgImagesStage = Utilities.createSubclass(BouncingSvgParticlesStage,
4545
initialize: function(benchmark, options)
4646
{
4747
BouncingSvgParticlesStage.prototype.initialize.call(this, benchmark, options);
48-
this.imageSrc = options["imageSrc"] || "resources/yin-yang.svg";
48+
this.imageSrc = options["imageSrc"] || "../resources/yin-yang.svg";
4949
},
5050

5151
createParticle: function()

0 commit comments

Comments
 (0)