Commit da95272
committed
The first frame of each ramp has an erroneously long frame duration
`RampController.didFinishInterval()` is called before `Controller.update()`
calls `this._sampler.record()`. This results in _rampStartIndex being off by one,
pointing to the frame before start of the ramp, which in turn causes us to compute
a long frame duration for this frame. This long frame feeds into the ramp controller
regression computation, throwing it off slightly, and adding noise.
Fix by having `Controller.update()` call `_sampler.record()` before it calls
`didFinishInterval()`, which requires calling `_sampler.record()` in each of
the three code paths.1 parent b9253e7 commit da95272
1 file changed
+5
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
165 | 165 | | |
166 | 166 | | |
167 | 167 | | |
| 168 | + | |
168 | 169 | | |
169 | 170 | | |
170 | 171 | | |
| |||
174 | 175 | | |
175 | 176 | | |
176 | 177 | | |
| 178 | + | |
| 179 | + | |
177 | 180 | | |
178 | 181 | | |
179 | 182 | | |
180 | | - | |
| 183 | + | |
| 184 | + | |
181 | 185 | | |
182 | 186 | | |
183 | | - | |
184 | 187 | | |
185 | 188 | | |
186 | 189 | | |
| |||
0 commit comments