Skip to content

Commit 98bb32f

Browse files
author
Luis Pardo
committed
Throw earlier when opening dbs
1 parent 57e7ecb commit 98bb32f

File tree

2 files changed

+4
-8
lines changed

2 files changed

+4
-8
lines changed

experimental/javascript-wc-indexeddb/dist/storage/indexedDB-manager.js

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,17 +21,15 @@ class IndexedDBManager {
2121
const deleteRequest = indexedDB.deleteDatabase(this.dbName);
2222

2323
deleteRequest.onerror = (event) => {
24-
// Continue despite error in deletion
25-
this.openDatabase(resolve, reject);
24+
reject(event.target.error);
2625
};
2726

2827
deleteRequest.onsuccess = () => {
2928
this.openDatabase(resolve, reject);
3029
};
3130

3231
deleteRequest.onblocked = () => {
33-
// Try opening anyway
34-
this.openDatabase(resolve, reject);
32+
reject(new Error("Database deletion blocked - please close other tabs using this database"));
3533
};
3634
});
3735
}

experimental/javascript-wc-indexeddb/src/storage/indexedDB-manager.js

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,17 +21,15 @@ class IndexedDBManager {
2121
const deleteRequest = indexedDB.deleteDatabase(this.dbName);
2222

2323
deleteRequest.onerror = (event) => {
24-
// Continue despite error in deletion
25-
this.openDatabase(resolve, reject);
24+
reject(event.target.error);
2625
};
2726

2827
deleteRequest.onsuccess = () => {
2928
this.openDatabase(resolve, reject);
3029
};
3130

3231
deleteRequest.onblocked = () => {
33-
// Try opening anyway
34-
this.openDatabase(resolve, reject);
32+
reject(new Error("Database deletion blocked - please close other tabs using this database"));
3533
};
3634
});
3735
}

0 commit comments

Comments
 (0)