Skip to content

Commit ca9d23c

Browse files
authored
Make the github action linter step fail in the case of issues (#374)
* Make the github action linter step fail in the case of issues * Run the formatter on the project
1 parent 3d78224 commit ca9d23c

File tree

3 files changed

+16
-2
lines changed

3 files changed

+16
-2
lines changed

.github/workflows/test.yml

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,17 @@ jobs:
2626
- name: Run linters
2727
run: |
2828
npm run format
29+
- name: Check if anything changed
30+
run: |
31+
git_status="`LC_ALL=C git status --porcelain --ignore-submodules -unormal 2>&1`"
32+
if [ -n "$git_status" ]; then
33+
printf "Some file(s) changed as the result of formatting, this means that you need to run the formatter on your patch.\n"
34+
printf "Here is what changed:\n"
35+
printf -- "$git_status\n\n"
36+
printf "And here is the diff:\n"
37+
git diff -U8
38+
exit 1
39+
fi
2940
build:
3041
name: Build
3142
runs-on: macos-latest

about.html

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,10 @@
1818
<h1 class="section-header">About Speedometer 3</h1>
1919
<div class="section-content">
2020
<p>Speedometer 3 is a benchmark for web browsers that measures Web application responsiveness by timing simulated user interactions on various workloads.</p>
21-
<p>It's developed as an open source project, with decisions being made under a <a href="https://github.com/WebKit/Speedometer/blob/main/Governance.md">multistakeholder governance model</a> between the three widely distributed web browser engine projects.
21+
<p>
22+
It's developed as an open source project, with decisions being made under a <a href="https://github.com/WebKit/Speedometer/blob/main/Governance.md">multistakeholder governance model</a> between the three widely distributed
23+
web browser engine projects.
24+
</p>
2225
<p>
2326
The following high level user journeys are implemented in the current version. Each of these journeys has one or more workloads which test important aspects of it - for example commonly used patterns, frameworks, or
2427
technologies.

resources/todomvc/architecture-examples/angular/angular.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,6 @@
9494
}
9595
},
9696
"cli": {
97-
"analytics": false
97+
"analytics": false
9898
}
9999
}

0 commit comments

Comments
 (0)