Skip to content

Commit d979723

Browse files
flashdesignoryflashdesignory
authored
Async Runner with Message Channel (#458)
1 parent d6b5ffe commit d979723

18 files changed

+147
-48
lines changed

‎resources/benchmark-runner.mjs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -409,7 +409,8 @@ export class BenchmarkRunner {
409409
async runSuite(suite) {
410410
// FIXME: Encapsulate more state in the SuiteRunner.
411411
// FIXME: Return and use measured values from SuiteRunner.
412-
const suiteRunnerClass = SUITE_RUNNER_LOOKUP[suite.type ?? "default"];
412+
const type = suite.type ?? ((params.useAsyncSteps && "async") || "default");
413+
const suiteRunnerClass = SUITE_RUNNER_LOOKUP[type];
413414
const suiteRunner = new suiteRunnerClass(this._frame, this._page, params, suite, this._client, this._measuredValues);
414415
await suiteRunner.run();
415416
}

‎resources/developer-mode.mjs

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ export function createDeveloperModeContainer() {
2121
settings.append(createUIForWarmupSuite());
2222
settings.append(createUIForWarmupBeforeSync());
2323
settings.append(createUIForSyncStepDelay());
24+
settings.append(createUIForAsyncSteps());
2425

2526
content.append(document.createElement("hr"));
2627
content.append(settings);
@@ -45,6 +46,12 @@ function createUIForWarmupSuite() {
4546
});
4647
}
4748

49+
function createUIForAsyncSteps() {
50+
return createCheckboxUI("Use Async Steps", params.useAsyncSteps, (isChecked) => {
51+
params.useAsyncSteps = isChecked;
52+
});
53+
}
54+
4855
function createCheckboxUI(labelValue, initialValue, paramsUpdateCallback) {
4956
const checkbox = document.createElement("input");
5057
checkbox.type = "checkbox";
@@ -255,7 +262,7 @@ function updateURL() {
255262
}
256263
}
257264

258-
const defaultParamKeys = ["iterationCount", "useWarmupSuite", "warmupBeforeSync", "waitBeforeSync"];
265+
const defaultParamKeys = ["iterationCount", "useWarmupSuite", "warmupBeforeSync", "waitBeforeSync", "useAsyncSteps"];
259266
for (const paramKey of defaultParamKeys) {
260267
if (params[paramKey] !== defaultParams[paramKey])
261268
url.searchParams.set(paramKey, params[paramKey]);

‎resources/newssite/news-next/dist/404.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
<!DOCTYPE html><html lang="en"><head><meta charSet="utf-8"/><meta name="viewport" content="width=device-width"/><meta name="next-head-count" content="2"/><link rel="preload" href="./_next/static/css/a0dca1379a01e5cf.css" as="style"/><link rel="stylesheet" href="./_next/static/css/a0dca1379a01e5cf.css" data-n-g=""/><noscript data-n-css=""></noscript><script defer="" nomodule="" src="./_next/static/chunks/polyfills-c67a75d1b6f99dc8.js"></script><script src="./_next/static/chunks/webpack-e50e9853db18b759.js" defer=""></script><script src="./_next/static/chunks/framework-2c79e2a64abdb08b.js" defer=""></script><script src="./_next/static/chunks/main-2ba37e62325cc71b.js" defer=""></script><script src="./_next/static/chunks/pages/_app-4fe6038a10d156ec.js" defer=""></script><script src="./_next/static/chunks/pages/_error-54de1933a164a1ff.js" defer=""></script><script src="./_next/static/slmX88Sy3MO0SLK8cVHnz/_buildManifest.js" defer=""></script><script src="./_next/static/slmX88Sy3MO0SLK8cVHnz/_ssgManifest.js" defer=""></script></head><body><div id="__next"></div><div id="settings-container"></div><div id="notifications-container"></div><script id="__NEXT_DATA__" type="application/json">{"props":{"pageProps":{"statusCode":404}},"page":"/_error","query":{},"buildId":"slmX88Sy3MO0SLK8cVHnz","assetPrefix":".","nextExport":true,"isFallback":false,"gip":true,"scriptLoader":[]}</script></body></html>
1+
<!DOCTYPE html><html lang="en"><head><meta charSet="utf-8"/><meta name="viewport" content="width=device-width"/><meta name="next-head-count" content="2"/><link rel="preload" href="./_next/static/css/a0dca1379a01e5cf.css" as="style"/><link rel="stylesheet" href="./_next/static/css/a0dca1379a01e5cf.css" data-n-g=""/><noscript data-n-css=""></noscript><script defer="" nomodule="" src="./_next/static/chunks/polyfills-c67a75d1b6f99dc8.js"></script><script src="./_next/static/chunks/webpack-e50e9853db18b759.js" defer=""></script><script src="./_next/static/chunks/framework-2c79e2a64abdb08b.js" defer=""></script><script src="./_next/static/chunks/main-2ba37e62325cc71b.js" defer=""></script><script src="./_next/static/chunks/pages/_app-77983e68be50f72a.js" defer=""></script><script src="./_next/static/chunks/pages/_error-54de1933a164a1ff.js" defer=""></script><script src="./_next/static/dKI4-ZnFPRMFEw-AlcuLr/_buildManifest.js" defer=""></script><script src="./_next/static/dKI4-ZnFPRMFEw-AlcuLr/_ssgManifest.js" defer=""></script></head><body><div id="__next"></div><div id="settings-container"></div><div id="notifications-container"></div><script id="__NEXT_DATA__" type="application/json">{"props":{"pageProps":{"statusCode":404}},"page":"/_error","query":{},"buildId":"dKI4-ZnFPRMFEw-AlcuLr","assetPrefix":".","nextExport":true,"isFallback":false,"gip":true,"scriptLoader":[]}</script></body></html>

‎resources/newssite/news-next/dist/_next/static/chunks/553-29fd8c03a09c7b37.js

Lines changed: 0 additions & 32 deletions
This file was deleted.

‎resources/newssite/news-next/dist/_next/static/chunks/743-fd706aeabb7828e3.js

Lines changed: 32 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎resources/newssite/news-next/dist/_next/static/chunks/pages/_app-4fe6038a10d156ec.js renamed to ‎resources/newssite/news-next/dist/_next/static/chunks/pages/_app-77983e68be50f72a.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎resources/newssite/news-next/dist/_next/static/chunks/pages/index-5268ea812327eb5e.js

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎resources/newssite/news-next/dist/_next/static/chunks/pages/index-7052462c4e106c39.js

Lines changed: 0 additions & 1 deletion
This file was deleted.

‎resources/newssite/news-next/dist/_next/static/css/2cf5163b53bb0adb.css

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎resources/newssite/news-next/dist/_next/static/css/69253d842fd3fbfd.css

Lines changed: 0 additions & 1 deletion
This file was deleted.

0 commit comments

Comments
 (0)