Adding pedantic warnings and treating warnings as errors, fixing some warnings

Author: VeithMetro

CMakeLists.txt

@@ -19,9 +19,30 @@
 cmake_minimum_required(VERSION 3.3)
 project(Libraries)
 
+find_package(WPEFramework)
+
 if (BUILD_REFERENCE)
     add_definitions (-DBUILD_REFERENCE=${BUILD_REFERENCE})
 endif()
 
+if(ENABLE_STRICT_COMPILER_SETTINGS)
+    if(CMAKE_CXX_COMPILER_ID MATCHES "Clang")
+        message(FATAL_ERROR "Compiling with Clang")
+        set(CMAKE_STRICT_COMPILER_SETTINGS "-Weverything -Wextra -Wpedantic -Werror")
+        set(CMAKE_STRICT_CXX_COMPILER_SETTINGS "${CMAKE_STRICT_COMPILER_SETTINGS} -Wnon-virtual-dtor")
+    elseif(${CMAKE_COMPILER_IS_GNUCXX})
+        message(STATUS "Compiling with GCC")
+        set(CMAKE_STRICT_COMPILER_SETTINGS "-Wall -Wextra -Wpedantic -Werror")
+        set(CMAKE_STRICT_CXX_COMPILER_SETTINGS "${CMAKE_STRICT_COMPILER_SETTINGS} -Wnon-virtual-dtor")
+    elseif(CMAKE_CXX_COMPILER_ID MATCHES "MSVC")
+        message(STATUS "Compiling with MS Visual Studio")
+        set(CMAKE_STRICT_COMPILER_SETTINGS "/W4")
+    else()
+        message(STATUS "Compiler ${CMAKE_CXX_COMPILER_ID}")
+    endif()
+    set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${CMAKE_STRICT_CXX_COMPILER_SETTINGS}")
+    set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${CMAKE_STRICT_COMPILER_SETTINGS}")
+endif()
+
 add_subdirectory(Source)
 

Source/bluetooth/BluetoothUtils.cpp

@@ -113,9 +113,9 @@ int BtUtilsHciDevba(int dev_id, bdaddr_t* bdaddr)
 
 int BtUtilsOtherBdaddr(int dd, int dev_id, long arg)
 {
-PUSH_WARNING(DISABLE_WARNING_MISSING_FIELD_INITIALIZERS)
-	struct hci_dev_info di = { .dev_id = static_cast<uint16_t>(dev_id) };
-POP_WARNING()
+	struct hci_dev_info di;
+	di.dev_id = static_cast<uint16_t>(dev_id);
+
 	if (ioctl(dd, HCIGETDEVINFO, (void*)&di))
 		return 0;
 
@@ -127,9 +127,8 @@ POP_WARNING()
 
 int BtUtilsSameBdaddr(int dd, int dev_id, long arg)
 {
-PUSH_WARNING(DISABLE_WARNING_MISSING_FIELD_INITIALIZERS)
-	struct hci_dev_info di = { .dev_id = static_cast<uint16_t>(dev_id) };
-POP_WARNING()
+	struct hci_dev_info di;
+	di.dev_id = static_cast<uint16_t>(dev_id);
 
 	if (ioctl(dd, HCIGETDEVINFO, (void*)&di))
 		return 0;

Source/bluetooth/HCISocket.h

@@ -813,8 +813,9 @@ namespace Bluetooth {
         // Create definitions for the HCI commands
         // ------------------------------------------------------------------------
         struct Command {
+PUSH_WARNING(DISABLE_WARNING_PEDANTIC)
             using Void = char[0];
-
+POP_WARNING()
             typedef CommandType<cmd_opcode_pack(OGF_LINK_CTL, OCF_INQUIRY), inquiry_cp, uint8_t>
                 Inquiry;