[MessageControl] Fix a shutdown issue (#361)

* Make sure that the Cleanups vector won't get destroyed before the Observer

* Add the Cleanups vector to the constructor for consistency

Author: VeithMetro

MessageControl/MessageControl.cpp

@@ -68,6 +68,7 @@ namespace Thunder {
         , _outputDirector()
         , _webSocketExporter()
         , _callback(nullptr)
+        , _cleaning()
         , _observer(*this)
         , _service(nullptr)
         , _dispatcherIdentifier(Messaging::MessageUnit::Instance().Identifier())

MessageControl/MessageControl.h

@@ -464,6 +464,7 @@ namespace Plugin {
         OutputList _outputDirector;
         Publishers::WebSocketOutput _webSocketExporter;
         MessageControl::ICollect::ICallback* _callback;
+        Cleanups _cleaning;
         Core::SinkType<Observer> _observer;
         PluginHost::IShell* _service;
         const string _dispatcherIdentifier;
@@ -475,7 +476,6 @@ namespace Plugin {
         Messaging::TraceFactoryType<Core::Messaging::IStore::WarningReporting, Core::Messaging::TextMessage> _warningReportingFactory;
         Messaging::TraceFactoryType<Core::Messaging::IStore::OperationalStream, Core::Messaging::TextMessage> _operationalStreamFactory;
         Messaging::TraceFactoryType<Core::Messaging::IStore::Assert, Core::Messaging::TextMessage> _assertFactory;
-        Cleanups _cleaning;
     };
 
 } // namespace Plugin