Fix for Postmortem Assert (#358)

Author: Karthick-Somasundaresan

DeviceIdentification/DeviceIdentification.cpp

@@ -118,7 +118,7 @@ namespace Plugin {
                 // It should have been the last reference we are releasing,
                 // so it should endup in a DESTRUCTION_SUCCEEDED, if not we
                 // are leaking...
-                ASSERT(result == Core::ERROR_DESTRUCTION_SUCCEEDED);
+                ASSERT( (result == Core::ERROR_CONNECTION_CLOSED) || (result == Core::ERROR_DESTRUCTION_SUCCEEDED));
 
                 // If this was running in a (container) process...
                 if (connection != nullptr) {

DeviceInfo/DeviceInfo.cpp

@@ -116,7 +116,7 @@ namespace Plugin {
                 // It should have been the last reference we are releasing,
                 // so it should endup in a DESTRUCTION_SUCCEEDED, if not we
                 // are leaking...
-                ASSERT(result == Core::ERROR_DESTRUCTION_SUCCEEDED);
+                ASSERT( (result == Core::ERROR_CONNECTION_CLOSED) || (result == Core::ERROR_DESTRUCTION_SUCCEEDED));
                 // The process can disappear in the meantime...
                 if (connection != nullptr) {
                     // But if it did not dissapear in the meantime, forcefully terminate it. Shoot to kill :-)

DisplayInfo/DisplayInfo.cpp

@@ -130,7 +130,7 @@ namespace Plugin {
                 // It should have been the last reference we are releasing, 
                 // so it should endup in a DESTRUCTION_SUCCEEDED, if not we
                 // are leaking...
-                ASSERT(result == Core::ERROR_DESTRUCTION_SUCCEEDED);
+                ASSERT( (result == Core::ERROR_CONNECTION_CLOSED) || (result == Core::ERROR_DESTRUCTION_SUCCEEDED));
 
                 // If this was running in a (container) process...
                 if (connection != nullptr) {

Messenger/Messenger.cpp

@@ -94,7 +94,7 @@ namespace Plugin {
                 // It should have been the last reference we are releasing,
                 // so it should end up in a DESCRUCTION_SUCCEEDED, if not we
                 // are leaking...
-                ASSERT(result == Core::ERROR_DESTRUCTION_SUCCEEDED);
+                ASSERT( (result == Core::ERROR_CONNECTION_CLOSED) || (result == Core::ERROR_DESTRUCTION_SUCCEEDED));
 
                 // If this was running in a (container) proccess...
                 if (connection != nullptr) {

OpenCDMi/OCDM.cpp

@@ -172,7 +172,7 @@ namespace Plugin {
                 // It should have been the last reference we are releasing,
                 // so it should end up in a DESCRUCTION_SUCCEEDED, if not we
                 // are leaking...
-                ASSERT(result == Core::ERROR_DESTRUCTION_SUCCEEDED);
+                ASSERT( (result == Core::ERROR_CONNECTION_CLOSED) || (result == Core::ERROR_DESTRUCTION_SUCCEEDED));
 
                 // If this was running in a (container) proccess...
                 if (connection != nullptr) {

Packager/Packager.cpp

@@ -92,7 +92,7 @@ namespace {
                 // It should have been the last reference we are releasing,
                 // so it should end up in a DESCRUCTION_SUCCEEDED, if not we
                 // are leaking ...
-                ASSERT(result == Core::ERROR_DESTRUCTION_SUCCEEDED);
+                ASSERT( (result == Core::ERROR_CONNECTION_CLOSED) || (result == Core::ERROR_DESTRUCTION_SUCCEEDED));
 
                 // If this was running in a (container) process ...
                 if (connection != nullptr) {

PerformanceMetrics/PerformanceMetrics.h

@@ -180,7 +180,7 @@ namespace Plugin {
                 if (_observable.IsValid() == true) {
                     _observable->Disable();
                     VARIABLE_IS_NOT_USED uint32_t result =_observable.Release(); 
-                    ASSERT(result == Core::ERROR_DESTRUCTION_SUCCEEDED);
+                    ASSERT( (result == Core::ERROR_CONNECTION_CLOSED) || (result == Core::ERROR_DESTRUCTION_SUCCEEDED));
                     ASSERT(_observable.IsValid() == false);
                 }
             }
@@ -203,7 +203,7 @@ namespace Plugin {
                     _observable->Deactivated(service);
                     _observable->Disable();
                     VARIABLE_IS_NOT_USED uint32_t result =_observable.Release(); 
-                    ASSERT(result == Core::ERROR_DESTRUCTION_SUCCEEDED);
+                    ASSERT( (result == Core::ERROR_CONNECTION_CLOSED) || (result == Core::ERROR_DESTRUCTION_SUCCEEDED));
                     ASSERT(_observable.IsValid() == false);            
                 }
             }

PlayerInfo/PlayerInfo.cpp

@@ -116,7 +116,7 @@ namespace Plugin {
                 RPC::IRemoteConnection* connection(_service->RemoteConnection(_connectionId));
                 VARIABLE_IS_NOT_USED uint32_t result = _player->Release();
                 _player = nullptr;
-                ASSERT(result == Core::ERROR_DESTRUCTION_SUCCEEDED);
+                ASSERT( (result == Core::ERROR_CONNECTION_CLOSED) || (result == Core::ERROR_DESTRUCTION_SUCCEEDED));
 
                 // The connection can disappear in the meantime...
                 if (connection != nullptr) {

RustBridge/RustBridge.cpp

@@ -118,7 +118,7 @@ namespace Thunder {
                     // It should have been the last reference we are releasing,
                     // so it should endup in a DESTRUCTION_SUCCEEDED, if not we
                     // are leaking...
-                    ASSERT(result == Core::ERROR_DESTRUCTION_SUCCEEDED);
+                    ASSERT( (result == Core::ERROR_CONNECTION_CLOSED) || (result == Core::ERROR_DESTRUCTION_SUCCEEDED));
 
                     // The process can disappear in the meantime...
                     if (connection != nullptr) {

WebKitBrowser/WebKitBrowser.cpp

@@ -204,7 +204,7 @@ namespace Plugin {
                 // It should have been the last reference we are releasing,
                 // so it should end up in a DESCRUCTION_SUCCEEDED, if not we
                 // are leaking...
-                ASSERT(result == Core::ERROR_DESTRUCTION_SUCCEEDED);
+                ASSERT( (result == Core::ERROR_CONNECTION_CLOSED) || (result == Core::ERROR_DESTRUCTION_SUCCEEDED));
 
                 // If this was running in a (container) process...
                 if (connection != nullptr) {