Skip to content

Commit 483137c

Browse files
authored
[PlayerInfo][Actions] Fixing a compile error, installing a package suddenly missing on the runner (#352)
* Looks like the 32-bit GStreamer must be installed somewhere else and not in the most typicial spot.. * Use the development template for testing * Formatting changes * See if building the libopkg has any effect on venv * For some reason we have to explicitly install python3-venv now.. * Parentheses around assignment used as truth value /home/runner/work/ThunderNanoServicesRDK/ThunderNanoServicesRDK/ThunderNanoServicesRDK/PlayerInfo/GStreamer/PlatformImplementation.cpp:61:17: error: suggest parentheses around assignment used as truth value [-Werror=parentheses] 61 | if (elements = std::move(GstUtils::GstRegistryGetElementForMediaType(decoderFactories.get(), std::move(mediaType)))) { | ^~ /home/runner/work/ThunderNanoServicesRDK/ThunderNanoServicesRDK/ThunderNanoServicesRDK/PlayerInfo/GStreamer/PlatformImplementation.cpp:64:24: error: suggest parentheses around assignment used as truth value [-Werror=parentheses] 64 | } else if (elements = std::move(GstUtils::GstRegistryGetElementForMediaType(parserFactories.get(), std::move(mediaType)))) { | ^~ /home/runner/work/ThunderNanoServicesRDK/ThunderNanoServicesRDK/ThunderNanoServicesRDK/PlayerInfo/GStreamer/PlatformImplementation.cpp: In instantiation of ‘static bool Thunder::Plugin::PlayerInfoImplementation::GstUtils::GstRegistryCheckElementsForMediaTypes(C, CodecIteratorList&) [with C = std::map<const std::__cxx11::basic_string<char>, const Thunder::Exchange::IPlayerProperties::VideoCodec>; CodecIteratorList = std::__cxx11::list<Thunder::Exchange::IPlayerProperties::VideoCodec>]’: /home/runner/work/ThunderNanoServicesRDK/ThunderNanoServicesRDK/ThunderNanoServicesRDK/PlayerInfo/GStreamer/PlatformImplementation.cpp:188:60: required from here /home/runner/work/ThunderNanoServicesRDK/ThunderNanoServicesRDK/ThunderNanoServicesRDK/PlayerInfo/GStreamer/PlatformImplementation.cpp:61:17: error: suggest parentheses around assignment used as truth value [-Werror=parentheses] 61 | if (elements = std::move(GstUtils::GstRegistryGetElementForMediaType(decoderFactories.get(), std::move(mediaType)))) { | ^~ /home/runner/work/ThunderNanoServicesRDK/ThunderNanoServicesRDK/ThunderNanoServicesRDK/PlayerInfo/GStreamer/PlatformImplementation.cpp:64:24: error: suggest parentheses around assignment used as truth value [-Werror=parentheses] 64 | } else if (elements = std::move(GstUtils::GstRegistryGetElementForMediaType(parserFactories.get(), std::move(mediaType)))) { | ^~ * Use the master template after testing is over
1 parent 95fee11 commit 483137c

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

.github/workflows/Linux build template.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ jobs:
2828
echo "deb http://archive.ubuntu.com/ubuntu/ jammy-updates main universe restricted multiverse" | sudo tee -a /etc/apt/sources.list
2929
sudo dpkg --add-architecture i386
3030
sudo apt-get update
31-
sudo apt install python3-pip build-essential cmake ninja-build libusb-1.0-0-dev autoconf automake libtool libtool-bin pkg-config ${{matrix.architecture == '32' && 'zlib1g-dev:i386 libssl-dev:i386 gcc-13-multilib g++-13-multilib libarchive-dev:i386 libcurl4-openssl-dev:i386 libgpgme-dev:i386 libgpg-error-dev:i386 libgstreamer1.0-dev:i386' || 'zlib1g-dev libssl-dev libarchive-dev libcurl4-openssl-dev libgpgme-dev libgpg-error-dev libgstreamer1.0-dev'}}
31+
sudo apt install python3-pip python3-venv build-essential cmake ninja-build libusb-1.0-0-dev autoconf automake libtool libtool-bin pkg-config ${{matrix.architecture == '32' && 'zlib1g-dev:i386 libssl-dev:i386 gcc-13-multilib g++-13-multilib libarchive-dev:i386 libcurl4-openssl-dev:i386 libgpgme-dev:i386 libgpg-error-dev:i386 libgstreamer1.0-dev:i386' || 'zlib1g-dev libssl-dev libarchive-dev libcurl4-openssl-dev libgpgme-dev libgpg-error-dev libgstreamer1.0-dev'}}
3232
python3 -m venv venv
3333
source venv/bin/activate
3434
pip install jsonref

PlayerInfo/GStreamer/PlatformImplementation.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,10 +58,10 @@ class PlayerInfoImplementation : public Exchange::IPlayerProperties {
5858
for (auto index: caps) {
5959

6060
MediaTypes mediaType{gst_caps_from_string(index.first.c_str())};
61-
if (elements = std::move(GstUtils::GstRegistryGetElementForMediaType(decoderFactories.get(), std::move(mediaType)))) {
61+
if ((elements = std::move(GstUtils::GstRegistryGetElementForMediaType(decoderFactories.get(), std::move(mediaType))))) {
6262
codecIteratorList.push_back(index.second);
6363

64-
} else if (elements = std::move(GstUtils::GstRegistryGetElementForMediaType(parserFactories.get(), std::move(mediaType)))) {
64+
} else if ((elements = std::move(GstUtils::GstRegistryGetElementForMediaType(parserFactories.get(), std::move(mediaType))))) {
6565

6666
for (GList* iterator = elements.get(); iterator; iterator = iterator->next) {
6767

0 commit comments

Comments
 (0)