Remove ProxyType entirely, as the lifetime of the string is managed by the queue after push

Author: VeithMetro

MessageControl/MessageOutput.cpp

@@ -132,7 +132,6 @@ namespace Publishers {
     UDPOutput::Channel::Channel(const Core::NodeId& nodeId)
         : Core::SocketDatagram(false, nodeId.Origin(), nodeId, Messaging::MessageUnit::Instance().DataSize(), 0)
         , _queue()
-        , _stringPool(ProxyPoolTypeSize)
     {
     }
     UDPOutput::Channel::~Channel()
@@ -150,12 +149,12 @@ namespace Publishers {
             _adminLock.Unlock();
         }
         else {
-            Core::ProxyType<string> msg = _queue.front();
+            string msg = _queue.front();
             _queue.pop();
             _adminLock.Unlock();
 
-            actualByteCount = std::min<uint16_t>(msg->size(), maxSendSize);
-            memcpy(dataFrame, msg->c_str(), actualByteCount);
+            actualByteCount = std::min<uint16_t>(msg.size(), maxSendSize);
+            memcpy(dataFrame, msg.c_str(), actualByteCount);
         }
 
         return (actualByteCount);
@@ -174,9 +173,7 @@ namespace Publishers {
     {
         _adminLock.Lock();
 
-        Core::ProxyType<string> msg = _stringPool.Element();
-        *msg = text;
-        _queue.push(msg);
+        _queue.push(text);
 
         _adminLock.Unlock();
 

MessageControl/MessageOutput.h

@@ -345,8 +345,6 @@ namespace Publishers {
 
     class UDPOutput : public IPublish {
     private:
-        static constexpr uint32_t ProxyPoolTypeSize = 10;
-
         class Channel : public Core::SocketDatagram {
         public:
             Channel() = delete;
@@ -364,8 +362,7 @@ namespace Publishers {
             uint16_t ReceiveData(uint8_t*, const uint16_t) override;
             void StateChange() override;
 
-            std::queue<Core::ProxyType<string>> _queue;
-            Core::ProxyPoolType<string> _stringPool;
+            std::queue<string> _queue;
             Core::CriticalSection _adminLock;
         };