Optimize with std::move to avoid all possible copies

Author: VeithMetro

MessageControl/MessageOutput.cpp

@@ -149,7 +149,7 @@ namespace Publishers {
             _adminLock.Unlock();
         }
         else {
-            const string msg = _queue.front();
+            string msg = std::move(_queue.front());
             _queue.pop();
             _adminLock.Unlock();
 
@@ -169,11 +169,11 @@ namespace Publishers {
     {
     }
 
-    void UDPOutput::Channel::Output(const string& text)
+    void UDPOutput::Channel::Output(string&& text)
     {
         _adminLock.Lock();
 
-        _queue.push(text);
+        _queue.emplace(std::move(text));
 
         _adminLock.Unlock();
 

MessageControl/MessageOutput.h

@@ -354,7 +354,7 @@ namespace Publishers {
             explicit Channel(const Core::NodeId& nodeId);
             ~Channel() override;
 
-            void Output(const string& text);
+            void Output(string&& text);
 
         private:
             uint16_t SendData(uint8_t* dataFrame, const uint16_t maxSendSize) override;